Make SUB_Remove non-virtual#737
Merged
Merged
Conversation
The `SUB_Remove` think function pointer was made virtual in aae9c80 as a workaround to fix weapons disappearing mid-round. This was later properly addressed in 429f83f, making the virtual declaration redundant. Hence I'm removing the virtual declaration for simplicity, and to avoid the needless vtable indirection overhead.
brysondev
approved these changes
Oct 16, 2024
AdamTadeusz
approved these changes
Oct 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The
SUB_Removethink function pointer was made virtual in aae9c80 as a workaround to fix weapons disappearing mid-round. This was later properly addressed in 429f83f, making the virtual declaration redundant. Hence I'm removing the virtual declaration for simplicity, and to avoid the needless vtable indirection overhead.Toolchain