Do not delete g_pNeoLoading ourselves, probably already done by engine

[nullsystem]

Description

Still getting crash here (user after free on dangling pointer?). Just don't handle it. It's also called on exit so it's unnecessary to even cleanup here anyway.

Toolchain

• Linux GCC Distro Native Arch/GCC 14

[Rainyan]

@nullsystem Do you have a crash dump for this, or repro steps?

[AdamTadeusz]

It's probably not noticeable unless you specifically run the game from visual studio in debug mode maybe?
https://github.com/user-attachments/assets/670be906-ef59-4d55-b9ef-f7251a0113e6

[nullsystem]

@Rainyan Repro step is just opening then closing, and it happens sometimes, sometimes it doesn't. If it happens it's on shutdown.

@AdamTadeusz Still a crash and rather anonying when on a debugger? Even for people on a release build and it happens, it'll end up filling up more dump files.

[AdamTadeusz]

@Rainyan Repro step is just opening then closing, and it happens sometimes, sometimes it doesn't. If it happens it's on shutdown.

@AdamTadeusz Still a crash and rather anonying when on a debugger?

This is on master, not this branch. Haven't verified this fixes the problem yet but yes its a common crash on master on exit when debugging

[Rainyan]

Ok, I can reproduce it too. Looking at the backtrace, it seems to indeed be a segfault at line

neo/mp/src/game/client/clientmode_shared.cpp

Line 330 in 9dc5d66

g_pNeoLoading->MarkForDeletion();

with the ECX register ("this" ptr of the thiscall) pointing to unaddressable memory at the time of the function call, which then signals SIGSEGV.

Tracing the ~CNeoLoading base dtor, it's invoked via

neo/mp/src/vgui2/vgui_controls/Panel.cpp

Line 1682 in 9dc5d66

delete this;

from the engine library before the ~ClientModeShared dtor is called, so it seems to indeed be a use-after-free on the g_pNeoLoading pointer. And since the CNeoLoading destructor is already being invoked by the engine, we should be safe to remove these lines without a memory leak.

[AdamTadeusz]

firefox moment?