Skip to content

Damage/killer info duration 60s->10s + Dismiss forever#718

Merged
nullsystem merged 1 commit into
NeotokyoRebuild:masterfrom
nullsystem:GH-717_DmgKillerInfo
Oct 15, 2024
Merged

Damage/killer info duration 60s->10s + Dismiss forever#718
nullsystem merged 1 commit into
NeotokyoRebuild:masterfrom
nullsystem:GH-717_DmgKillerInfo

Conversation

@nullsystem

Copy link
Copy Markdown
Collaborator

Description

  • 60s was too long, turned down to 10s
  • Add the ability to dismiss and not have the info for the rest of the match

Toolchain

  • Linux GCC Distro Native Arch/GCC 14

Linked Issues

brysondev
brysondev previously approved these changes Oct 13, 2024
@kassibuss kassibuss added this to the v9.1-prealpha milestone Oct 13, 2024
@nullsystem
nullsystem requested a review from a team October 13, 2024 15:38
Comment thread mp/src/game/server/neo/neo_player.cpp Outdated
Comment thread mp/src/game/server/neo/neo_player.cpp Outdated
Comment thread mp/src/game/server/neo/neo_player.cpp Outdated
* 60s was too long, turned down to 10s
* Add the ability to dismiss and not have the info for the rest of the
  match
* fixes NeotokyoRebuild#717

@brysondev brysondev left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Enums my beloved

@nullsystem nullsystem added the New Changes for Reviewers New changes has been made. This label is mostly to notify reviewers. label Oct 13, 2024
@brysondev
brysondev requested a review from a team October 14, 2024 09:17

@Rainyan Rainyan left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might wanna eventually move the HUD "never show" option as part of the client's FCVAR_USERINFO, so the preference is not tied to the gamerules entity lifetime, and can be set with a config file by the user.

@nullsystem
nullsystem merged commit 6db9b37 into NeotokyoRebuild:master Oct 15, 2024
@nullsystem
nullsystem deleted the GH-717_DmgKillerInfo branch May 7, 2025 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

New Changes for Reviewers New changes has been made. This label is mostly to notify reviewers.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Damage/killer info menu duration is too long

4 participants