Fix local player's players killed report not resetting each round#2018
Merged
nullsystem merged 3 commits intoJul 21, 2026
Merged
Conversation
nullsystem
added
the
Tournament Priority
nullsystem
force-pushed
the
GH-1874_DmgReportRewrite
branch
from
July 13, 2026 19:21
cb4d2d9 to
7914eb1
Compare
nullsystem
changed the title
Two fixes: First m_bFirstAliveTick never gets updated when the player
respawns past the first respawn since not dying on a round will not
turn this to true and the respawn resets through m_bFirstAliveTick
for local player in PreThink doesn't get utilized. This may also
be the cause of other non-reset issues people seen before, but this
has affected the killed players report especially.
Second, move the array from C_NEO_Player into its own global array
as really it's only a single instance (for the local player) and
pointless for every single C_NEO_Player to hold it. For sanity
check, change from it being entity index array based to UserID
based to be sure which is which when its displayed and not affected
by entity index changes.
Killer info/scoreboard:
- Checking for pre-round freeze in killer_info no longer needed
- Now the c_neo_player first tick alive got fixed, can just do it
there.
- Use MAX_PLAYERS_ARRAY_SAFE
- Move local player check
* fixes NeotokyoRebuild#1874
nullsystem
force-pushed
the
GH-1874_DmgReportRewrite
branch
from
July 13, 2026 19:59
7914eb1 to
3cbdb97
Compare
nullsystem
marked this pull request as ready for review
July 13, 2026 20:01
nullsystem
changed the title
Masterkatze
reviewed
Jul 19, 2026
Contributor
|
Would clearing on the EDIT: It's defined in |
sunmachine
suggested changes
Jul 19, 2026
Contributor
There was a problem hiding this comment.
This is what I mean from my comment before. Feel free to explain why this isn't the way, but I think it'll avoid the edge-cases caused by waiting until the first alive tick.
sunmachine
reviewed
Jul 19, 2026
sunmachine
reviewed
Jul 19, 2026
Collaborator
Author
|
@sunmachine I think first alive tick also covers when players are allowed to respawn within the round (DM/TDM/JGR) which round_start won't, also the context of the report is for when the player's alive since the latest spawning in so first tick makes more sense. |
Collaborator
Author
|
@Masterkatze Changes based on code review: 71703f8 |
sunmachine
approved these changes
Jul 19, 2026
Masterkatze
approved these changes
Jul 20, 2026
sunzenshen
approved these changes
Jul 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Two fixes: First m_bFirstAliveTick never gets updated when the player respawns past the first respawn since not dying on a round will not turn this to true and the respawn resets through m_bFirstAliveTick for local player in PreThink doesn't get utilized. This may also be the cause of other non-reset issues people seen before, but this has affected the killed players report especially.
Second, move the array from C_NEO_Player into its own global array as really it's only a single instance (for the local player) and pointless for every single C_NEO_Player to hold it. For sanity check, change from it being entity index array based to UserID based to be sure which is which when its displayed and not affected by entity index changes.
Killer info/scoreboard:
there.
Toolchain
Linked Issues