Skip to content

Discourage bots from pathing through deadly areas #1739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sunzenshen merged 2 commits into from
Mar 1, 2026
Merged

Discourage bots from pathing through deadly areas #1739

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
85051d2
Area avoidance rebrand
sunzenshen Feb 26, 2026
3c5b4b6
Discourage bots from taking deadly paths
sunzenshen Feb 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 19 additions & 3 deletions src/game/server/neo/bot/behavior/neo_bot_behavior.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,6 +183,22 @@ ActionResult< CNEOBot > CNEOBotMainAction::Update( CNEOBot *me, float interval )
//---------------------------------------------------------------------------------------------
EventDesiredResult<CNEOBot> CNEOBotMainAction::OnKilled( CNEOBot *me, const CTakeDamageInfo& info )
{
// Encourage bots to avoid areas that are deadly, taking into account everyone's death locations
// Intended to add some variance to pathing for similar starting scenarios
if ( const CNavArea *navArea = me->GetLastKnownArea() )
{
CNEOBotPathReservations()->IncrementAreaAvoidPenalty( navArea->GetID(), neo_bot_path_reservation_killed_penalty.GetFloat() );
}
else
{
// Fallback if GetLastKnownArea is null, try finding nearest nav area
CNavArea *nearestArea = TheNavMesh->GetNearestNavArea( me->GetAbsOrigin() );
if ( nearestArea )
{
CNEOBotPathReservations()->IncrementAreaAvoidPenalty( nearestArea->GetID(), neo_bot_path_reservation_killed_penalty.GetFloat() );
}
}

return TryChangeTo( new CNEOBotDead, RESULT_CRITICAL, "I died!" );
}

Expand Down Expand Up @@ -252,15 +268,15 @@ EventDesiredResult< CNEOBot > CNEOBotMainAction::OnStuck( CNEOBot *me )
// so the overall fairness may balance out for both teams sharing common sticking points.
if ( const CNavArea *navArea = me->GetLastKnownArea() )
{
CNEOBotPathReservations()->IncrementAreaStuckPenalty( navArea->GetID() );
CNEOBotPathReservations()->IncrementAreaAvoidPenalty( navArea->GetID(), neo_bot_path_reservation_onstuck_penalty.GetFloat() );
}
else
{
// Fallback if GetLastKnownArea is null, try finding nearest nav area
CNavArea *nearestArea = TheNavMesh->GetNearestNavArea( me->GetAbsOrigin() );
if ( nearestArea )
{
CNEOBotPathReservations()->IncrementAreaStuckPenalty( nearestArea->GetID() );
CNEOBotPathReservations()->IncrementAreaAvoidPenalty( nearestArea->GetID(), neo_bot_path_reservation_onstuck_penalty.GetFloat() );
}
}

Expand All @@ -273,7 +289,7 @@ EventDesiredResult< CNEOBot > CNEOBotMainAction::OnStuck( CNEOBot *me )
{
if ( nextSegment->area )
{
CNEOBotPathReservations()->IncrementAreaStuckPenalty( nextSegment->area->GetID() );
CNEOBotPathReservations()->IncrementAreaAvoidPenalty( nextSegment->area->GetID(), neo_bot_path_reservation_onstuck_penalty.GetFloat() );
}
}
}
Expand Down
2 changes: 1 addition & 1 deletion src/game/server/neo/bot/neo_bot_path_cost.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ float CNEOBotPathCost::operator()(CNavArea* baseArea, CNavArea* fromArea, const
if ( !m_bIgnoreReservations && (m_routeType != FASTEST_ROUTE) )
{
cost += CNEOBotPathReservations()->GetPredictedFriendlyPathCount(area->GetID(), m_me->GetTeamNumber()) * neo_bot_path_reservation_penalty.GetFloat();
cost += CNEOBotPathReservations()->GetAreaStuckPenalty(area->GetID());
cost += CNEOBotPathReservations()->GetAreaAvoidPenalty(area->GetID());

if (m_routeType == SAFEST_ROUTE)
{
Expand Down
33 changes: 18 additions & 15 deletions src/game/server/neo/bot/neo_bot_path_reservation.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,11 +23,14 @@ ConVar neo_bot_path_reservation_penalty("neo_bot_path_reservation_penalty", "100
ConVar neo_bot_path_reservation_friendly_penalty_enable("neo_bot_path_reservation_friendly_penalty_enable", "1", FCVAR_NONE,
"Whether to update or retrieve the area friendly reservation penalty.", true, 0, true, 1);

ConVar neo_bot_path_reservation_onstuck_penalty_enable("neo_bot_path_reservation_onstuck_penalty_enable", "1", FCVAR_NONE,
"Whether to update or retrieve the area onstuck penalty.", true, 0, true, 1);
ConVar neo_bot_path_reservation_avoid_penalty_enable("neo_bot_path_reservation_avoid_penalty_enable", "1", FCVAR_NONE,
"Whether to update or retrieve the area avoid penalty.", true, 0, true, 1);

ConVar neo_bot_path_reservation_killed_penalty("neo_bot_path_reservation_killed_penalty", "10", FCVAR_NONE,
"Path selection penalty added to a nav area each time a bot dies moving through that area.", true, 0, false, 0);

ConVar neo_bot_path_reservation_onstuck_penalty("neo_bot_path_reservation_onstuck_penalty", "10000", FCVAR_NONE,
"Path selection penalty added to a nav area each time a bot gets stuck moving through that area.", true, 0, true, 1000000);
"Path selection penalty added to a nav area each time a bot gets stuck moving through that area.", true, 0, false, 0);



Expand Down Expand Up @@ -248,7 +251,7 @@ void CNEOBotPathReservationSystem::Clear()
m_AreaPathCounts[team].RemoveAll();
}
m_BotReservedAreas.RemoveAll();
m_AreaOnStuckPenalties.RemoveAll();
m_AreaAvoidPenalties.RemoveAll();
}

//-------------------------------------------------------------------------------------------------
Expand Down Expand Up @@ -308,34 +311,34 @@ int CNEOBotPathReservationSystem::GetPredictedFriendlyPathCount( int areaID, int
}

//-------------------------------------------------------------------------------------------------
void CNEOBotPathReservationSystem::IncrementAreaStuckPenalty(unsigned int navAreaID)
void CNEOBotPathReservationSystem::IncrementAreaAvoidPenalty(unsigned int navAreaID, float penaltyAmount)
{
if ( !neo_bot_path_reservation_onstuck_penalty_enable.GetBool() )
if ( !neo_bot_path_reservation_avoid_penalty_enable.GetBool() )
{
return;
}

unsigned short index = m_AreaOnStuckPenalties.Find(navAreaID);
if (index == m_AreaOnStuckPenalties.InvalidIndex())
unsigned short index = m_AreaAvoidPenalties.Find(navAreaID);
if (index == m_AreaAvoidPenalties.InvalidIndex())
{
index = m_AreaOnStuckPenalties.Insert(navAreaID, 0.0f);
index = m_AreaAvoidPenalties.Insert(navAreaID, 0.0f);
}

m_AreaOnStuckPenalties[index] += neo_bot_path_reservation_onstuck_penalty.GetFloat();
m_AreaAvoidPenalties[index] += penaltyAmount;
}

//-------------------------------------------------------------------------------------------------
float CNEOBotPathReservationSystem::GetAreaStuckPenalty(unsigned int navAreaID) const
float CNEOBotPathReservationSystem::GetAreaAvoidPenalty(unsigned int navAreaID) const
{
if ( !neo_bot_path_reservation_onstuck_penalty_enable.GetBool() )
if ( !neo_bot_path_reservation_avoid_penalty_enable.GetBool() )
{
return 0.0f;
}

unsigned short index = m_AreaOnStuckPenalties.Find(navAreaID);
if (index != m_AreaOnStuckPenalties.InvalidIndex())
unsigned short index = m_AreaAvoidPenalties.Find(navAreaID);
if (index != m_AreaAvoidPenalties.InvalidIndex())
{
return m_AreaOnStuckPenalties[index];
return m_AreaAvoidPenalties[index];
}
return 0.0f;
}
10 changes: 6 additions & 4 deletions src/game/server/neo/bot/neo_bot_path_reservation.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ class CNEOBotPathReservationSystem
return lhs.GetSerialNumber() < rhs.GetSerialNumber();
}

CNEOBotPathReservationSystem() : m_BotReservedAreas(EHandleLessFunc), m_AreaOnStuckPenalties(DefLessFunc(unsigned int))
CNEOBotPathReservationSystem() : m_BotReservedAreas(EHandleLessFunc), m_AreaAvoidPenalties(DefLessFunc(unsigned int))
{
for (int i = 0; i < TEAM__TOTAL; ++i)
{
Expand All @@ -61,8 +61,8 @@ class CNEOBotPathReservationSystem
void DecrementPredictedFriendlyPathCount( int areaID, int teamID );
int GetPredictedFriendlyPathCount( int areaID, int teamID ) const;

void IncrementAreaStuckPenalty(unsigned int navAreaID);
float GetAreaStuckPenalty(unsigned int navAreaID) const;
void IncrementAreaAvoidPenalty(unsigned int navAreaID, float penaltyAmount);
float GetAreaAvoidPenalty(unsigned int navAreaID) const;

// Allow the global accessor to access private members if needed, though constructor handles init now.
friend CNEOBotPathReservationSystem* CNEOBotPathReservations();
Expand All @@ -71,7 +71,7 @@ class CNEOBotPathReservationSystem
CUtlMap<int, ReservationInfo> m_Reservations[TEAM__TOTAL];
CUtlMap<EHANDLE, BotReservedAreas_t> m_BotReservedAreas;
CUtlMap<int, int> m_AreaPathCounts[TEAM__TOTAL];
CUtlMap<unsigned int, float> m_AreaOnStuckPenalties;
CUtlMap<unsigned int, float> m_AreaAvoidPenalties;
};


Expand All @@ -81,3 +81,5 @@ extern ConVar neo_bot_path_reservation_enable;
extern ConVar neo_bot_path_reservation_penalty;
extern ConVar neo_bot_path_reservation_duration;
extern ConVar neo_bot_path_reservation_distance;
extern ConVar neo_bot_path_reservation_onstuck_penalty;
extern ConVar neo_bot_path_reservation_killed_penalty;