Repository navigation
Conversation
karim-en
reviewed
Oct 14, 2026
| #[near] | ||
| impl Contract { | ||
| /// Expiry height of each pending transaction (`None` if not found). 0 means it never expires. | ||
| pub fn list_btc_pending_expiry_heights( |
Author
There was a problem hiding this comment.
I was unsure whether to add this method or not, but in the end I decided to add it.
It's needed in case a transaction gets stuck and doesn't even submitted it into the mempool — this way it will be easiest to check its expiry_height. Otherwise, we would have to parse the transaction.
I don't have a strong opinion about this method.
karim-en
reviewed
Oct 14, 2026
| require!( | ||
| actual_received_amount >= min_received_amount | ||
| && actual_received_amount <= max_received_amount, | ||
| actual_received_amount == expected_received_amount, |
Author
There was a problem hiding this comment.
Yes, and I think it's fairer to the user this way.
WASM size
Fails above +2% growth (ignoring deltas under 1024 bytes).
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes for the QA / Informational findings from the audit.
actions are pinned to commit SHAs;
cargo-near is pinned to a specific version and its SHA-256 is verified;
build (contents: read) and publish (contents: write) run as separate jobs;
releases now include checksums.sha256.