You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Audio layer: three small defects (unguarded outputConvolver, mute button keyed on channel.mute, name undefined in a convolver error) #201
chrome/player/ui/audio/AudioConfigManager.mjs (updateChannelCount): this.outputConvolver.updateChannelCount(); }).catch((e) => { }); while the field is only set if (OutputConvolver.isSupported()); upstream of it this.mixerNode.channelCount = outputChannelCount; can throw and this.outputChannelCount is never updated there (ChannelUpmixer then repeats the set every call). Harmless on Firefox today, but any throw in the chain vanishes in the empty catch. Fix: this.outputConvolver?.updateChannelCount(), log in the catch, update outputChannelCount.
chrome/player/ui/audio/AudioChannelMixer.mjs: els.muteButton.classList.toggle('active', channel.mute); while the field is muted (the line above: channel.muted = !channel.muted;). It works only because toggle(name, undefined) flips; once anything else changes muted while the element is live (a profile applied), the button shows the opposite of the state. Fix: channel.muted.
chrome/player/ui/audio/OutputConvolver.mjs: throw new Error('Could not decode impulse response: ' + name); has no name in scope (the parameter is file), so the message reads the window's name. Fix: file.name.
Confidence: high.
From a line-by-line code review of the tree at 41363fd (2026-10-02). Each claim above was checked against the source before filing; the reproduction steps and line references are as of that commit.
Activity