Fix Darwin writeWithoutResponse queue completion - #272
Open
fotiDim wants to merge 2 commits into
Open
Conversation
Align iOS/macOS write-without-response completion with other platforms by completing when CoreBluetooth accepts writes and only deferring when the buffer is full. This resolves queue stalls and throughput degradation seen with QueueType.global/perDevice on Apple (#271). Co-authored-by: Cursor <cursoragent@cursor.com>
Align package metadata and changelog header with the Darwin write-without-response queue fix release. Co-authored-by: Cursor <cursoragent@cursor.com>
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
fotiDim
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
withoutResponsewrite flow to complete when CoreBluetooth accepts writes (canSendWriteWithoutResponse) instead of waiting onperipheralIsReadyfor every write2.1.2inpubspec.yamlandCHANGELOG.mdTest plan
flutter test test/ble_command_queue_test.dart test/queue_test.dartQueueType.globalandQueueType.perDeviceusingwithoutResponse: truewritesMade with Cursor