Repository navigation
Python3 warning for dev branch Readme - #148
Merged
Merged
Conversation
* Update README.md * Update snapcraft.yaml * Overalls & Codacy badge fix * Removing snap for master push
Fixed a few issues with Naomi 2.2
Updating Forked Master Branch
Updating Forked Dev Branch
redragonx
approved these changes
Jan 11, 2019
redragonx
left a comment
redragonx
left a comment
Member
There was a problem hiding this comment.
Looks good, thanks @Longshotpro2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Until the 3.0 release, there needs to be a notice in the readme that states there was a change so new contributors are made aware before developing
Related Issue
Specific issue for this PR
Context issue for this PR
Motivation and Context
If someone updates their existing Naomi installation without running the new setup script to install the proper changes, Naomi breaks. Between the changes already made and bringing attention to the change on the readme there would be multiple places denoting the change, lessening the chance of someone inadvertently breaking Naomi.
How Has This Been Tested?
An alert image was added to the website directory that is then implemented into the readme for display.
Types of changes
Checklist: