Drop thrust::counting_iterator in favor of cuda::counting_iterator - #2958
Merged
rapids-bot[bot] merged 2 commits intoFeb 19, 2026
Conversation
aamijar
added
non-breaking
aamijar
approved these changes
Feb 18, 2026
divyegala
approved these changes
Feb 19, 2026
Member
|
/merge |
rapids-bot Bot
pushed a commit
to NVIDIA/cuvs
that referenced
this pull request
Feb 20, 2026
Follow up to NVIDIA/raft#2958. Authors: - Anupam (https://github.com/aamijar) Approvers: - Divye Gala (https://github.com/divyegala) - Bradley Dice (https://github.com/bdice) URL: #1825
rapids-bot Bot
pushed a commit
to NVIDIA/cuvs
that referenced
this pull request
Feb 23, 2026
…unting_iterator` (#1826) This commit moves the use of `thrust::make_counting_iterator` to `cuda::make_counting_iterator`, much like in NVIDIA/raft#2958. This change was initally done to fix the compile error one saw because of the use of `thrust::make_counting_iterator`: ``` │ │ $SRC_DIR/cpp/tests/neighbors/all_neighbors/../../../src/neighbors/detail/knn_brute_force.cuh(230): error: namespace "thrust" has no member "make_counting_iterator" │ │ auto count = thrust::make_counting_iterator<IndexType>(0); │ │ ^ │ │ $SRC_DIR/cpp/tests/neighbors/all_neighbors/../../../src/neighbors/detail/knn_brute_force.cuh(230): error: type name is not allowed │ │ auto count = thrust::make_counting_iterator<IndexType>(0); ``` The RAPIDS projects seem to be moving away from using the thrust function, and switching to the cuda version of the same. (Refer to NVIDIA/raft#2958.) This change moves cuVS in that direction. Authors: - MithunR (https://github.com/mythrocks) Approvers: - Jinsol Park (https://github.com/jinsolp) - Divye Gala (https://github.com/divyegala) URL: #1826
tfeher
pushed a commit
to Stardust-SJF/cuvs_rabitq
that referenced
this pull request
Mar 3, 2026
…unting_iterator` (NVIDIA#1826) This commit moves the use of `thrust::make_counting_iterator` to `cuda::make_counting_iterator`, much like in NVIDIA/raft#2958. This change was initally done to fix the compile error one saw because of the use of `thrust::make_counting_iterator`: ``` │ │ $SRC_DIR/cpp/tests/neighbors/all_neighbors/../../../src/neighbors/detail/knn_brute_force.cuh(230): error: namespace "thrust" has no member "make_counting_iterator" │ │ auto count = thrust::make_counting_iterator<IndexType>(0); │ │ ^ │ │ $SRC_DIR/cpp/tests/neighbors/all_neighbors/../../../src/neighbors/detail/knn_brute_force.cuh(230): error: type name is not allowed │ │ auto count = thrust::make_counting_iterator<IndexType>(0); ``` The RAPIDS projects seem to be moving away from using the thrust function, and switching to the cuda version of the same. (Refer to NVIDIA/raft#2958.) This change moves cuVS in that direction. Authors: - MithunR (https://github.com/mythrocks) Approvers: - Jinsol Park (https://github.com/jinsolp) - Divye Gala (https://github.com/divyegala) URL: NVIDIA#1826
landrumb
pushed a commit
to landrumb/cuvs
that referenced
this pull request
Jul 8, 2026
Follow up to NVIDIA/raft#2958. Authors: - Anupam (https://github.com/aamijar) Approvers: - Divye Gala (https://github.com/divyegala) - Bradley Dice (https://github.com/bdice) URL: NVIDIA#1825
landrumb
pushed a commit
to landrumb/cuvs
that referenced
this pull request
Jul 8, 2026
…unting_iterator` (NVIDIA#1826) This commit moves the use of `thrust::make_counting_iterator` to `cuda::make_counting_iterator`, much like in NVIDIA/raft#2958. This change was initally done to fix the compile error one saw because of the use of `thrust::make_counting_iterator`: ``` │ │ $SRC_DIR/cpp/tests/neighbors/all_neighbors/../../../src/neighbors/detail/knn_brute_force.cuh(230): error: namespace "thrust" has no member "make_counting_iterator" │ │ auto count = thrust::make_counting_iterator<IndexType>(0); │ │ ^ │ │ $SRC_DIR/cpp/tests/neighbors/all_neighbors/../../../src/neighbors/detail/knn_brute_force.cuh(230): error: type name is not allowed │ │ auto count = thrust::make_counting_iterator<IndexType>(0); ``` The RAPIDS projects seem to be moving away from using the thrust function, and switching to the cuda version of the same. (Refer to NVIDIA/raft#2958.) This change moves cuVS in that direction. Authors: - MithunR (https://github.com/mythrocks) Approvers: - Jinsol Park (https://github.com/jinsolp) - Divye Gala (https://github.com/divyegala) URL: NVIDIA#1826
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.