Skip to content

Fix test pipeline#246

Merged
maxjeblick merged 2 commits into
mainfrom
max/fix_tests
Jun 17, 2026
Merged

Fix test pipeline#246
maxjeblick merged 2 commits into
mainfrom
max/fix_tests

Conversation

@maxjeblick

@maxjeblick maxjeblick commented Jun 17, 2026

Copy link
Copy Markdown
Collaborator

PR description

WIP PR to fix CI/CD pipeline. Fixes #245

Checklist

Before submitting a PR, please make sure:

  • Tests are working (make test)

  • Code is formatted correctly (make style, on errors try fix with make format)

  • Copyright header is included

  • All commits are signed-off using git commit -s

  • (new press) mypress_press.py is in the presses directory

  • (new press) MyPress is in __init__.py

  • (new press) README.md is updated with a 1 liner about the new press in the Available presses section

  • (new press) New press is in the default_presses list in tests/default_presses.py

  • (new press) A docstring is provided that follows the same structure as the existing ones

Signed-off-by: Maximilian Jeblick <maximilianjeblick@gmail.com>
@copy-pr-bot

copy-pr-bot Bot commented Jun 17, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@maxjeblick

Copy link
Copy Markdown
Collaborator Author

/ok to test bfd25dd

@maxjeblick

Copy link
Copy Markdown
Collaborator Author

/ok to test 45a3e32

Signed-off-by: Maximilian Jeblick <maximilianjeblick@gmail.com>
@maxjeblick

Copy link
Copy Markdown
Collaborator Author

/ok to test 919268a

@SimJeg SimJeg left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks a lot

@maxjeblick maxjeblick merged commit d689d7f into main Jun 17, 2026
3 checks passed
@maxjeblick maxjeblick deleted the max/fix_tests branch June 17, 2026 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tests failing

2 participants