Improve niah test#133
Merged
Merged
Conversation
Signed-off-by: alessiodevoto <devoto.alessio@gmail.com>
Signed-off-by: alessiodevoto <devoto.alessio@gmail.com>
Signed-off-by: alessiodevoto <devoto.alessio@gmail.com>
Signed-off-by: alessiodevoto <devoto.alessio@gmail.com>
Signed-off-by: alessiodevoto <devoto.alessio@gmail.com>
Collaborator
Author
|
/ok to test bf80954 |
Contributor
|
Another issue, fix the dataset by llama's tokenizer will result in longer sequence in NIAH-like tasks for others, like Qwen family, since they use different lengths in digitals for one token. That usually leads to a lower performance for Qwen in KVPress eval utilities. |
Collaborator
Author
|
Hi @JoelSeniorLiang, true! That only applies to RULER though, where we have pre-computed lengths. Here I wanted to avoid this problem (as you said it is important for NIAH), so we tokenize with the model's own tokenizer and count length and depth with that one ! |
Signed-off-by: alessiodevoto <devoto.alessio@gmail.com>
Collaborator
Author
|
/ok to test b51f0fd |
Signed-off-by: alessiodevoto <devoto.alessio@gmail.com>
Collaborator
Author
|
/ok to test a99fcf2 |
Jack-Yu-815
approved these changes
Sep 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR description
This PR contains minimal improvements over the recently merged NIAH test. It allows to insert the needle at different depths (to avoid loading the model in memory multiple times) and fixes a minor bug in the evaluation pipeline, allowing for model = "auto".
Checklist
make test)make style, on errors try fix withmake format)git commit -smypress_press.pyis in thepressesdirectoryMyPressis in__init__.pyREADME.mdis updated with a 1 liner about the new press in the Available presses sectiondefault_presseslist intests/default_presses.py