Skip to content

chore(xidburst): remove end time to align with UI - #58

Merged
emilyzhangbg merged 1 commit into
mainfrom
feat/xidburst-timestamp
Sep 2, 2026
Merged

chore(xidburst): remove end time to align with UI#58
emilyzhangbg merged 1 commit into
mainfrom
feat/xidburst-timestamp

Conversation

@emilyzhangbg

@emilyzhangbg emilyzhangbg commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Description

QA Bug: https://nvbugspro.nvidia.com/bug/6702189

Remove End Time, leaving xidburst describe to only show Start Time and Duration.

Checklist

Summary by CodeRabbit

  • Changes
    • Removed the burst end-time field from the XID burst description table.

@coderabbitai

coderabbitai Bot commented Sep 2, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 6a17e537-4b28-4470-adb2-e067f1a6661f

📥 Commits

Reviewing files that changed from the base of the PR and between cc8e76a and 9fe218d.

📒 Files selected for processing (1)
  • internal/cmd/xidburst/xidburst.go
💤 Files with no reviewable changes (1)
  • internal/cmd/xidburst/xidburst.go

Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review.


📝 Walkthrough

Walkthrough

The XID burst describe table no longer displays the burst end-time field.

Changes

XID burst output

Layer / File(s) Summary
Remove burst end-time row
internal/cmd/xidburst/xidburst.go
The describe output no longer renders the END TIME row.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 9fe21

This is a narrowly scoped timestamp-formatting change, and no actionable merge-blocking risk remains beyond normal checks and review.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 5 functions across 3 files.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the change in the diff: removing the XID burst end-time field to match the UI.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/xidburst-timestamp

Comment @coderabbitai help to get the list of available commands.

Signed-off-by: Emily Zhang <emizhang@nvidia.com>
@emilyzhangbg
emilyzhangbg force-pushed the feat/xidburst-timestamp branch from cc8e76a to 9fe218d Compare September 2, 2026 20:55
@emilyzhangbg emilyzhangbg changed the title fix: use fixed-width fractional seconds for xidburst timestamps chore(xidburst): remove end time to align with UI Sep 2, 2026
@emilyzhangbg
emilyzhangbg merged commit b04d199 into main Sep 2, 2026
7 checks passed
@emilyzhangbg
emilyzhangbg deleted the feat/xidburst-timestamp branch September 2, 2026 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants