Enable green context in Barrier#448
Merged
rapids-bot[bot] merged 7 commits intoNVIDIA:branch-25.10from Oct 7, 2025
Merged
Conversation
hlinsen
added
non-breaking
chris-maes
reviewed
Oct 6, 2025
chris-maes
reviewed
Oct 6, 2025
chris-maes
approved these changes
Oct 6, 2025
Contributor
chris-maes
left a comment
chris-maes
left a comment
There was a problem hiding this comment.
LGTM. But perhaps someone with more experience with CUDA driver calls should check?
bdice
approved these changes
Oct 6, 2025
Contributor
bdice
left a comment
bdice
left a comment
There was a problem hiding this comment.
I have a couple of questions but nothing worth blocking over.
| CUDA::curand | ||
| CUDA::cusolver | ||
| TBB::tbb | ||
| CUDA::cuda_driver |
Contributor
There was a problem hiding this comment.
I guess this does a dlopen now, rather than dynamically linking, which is why this is removed?
Contributor
Author
There was a problem hiding this comment.
I haven't checked the trace but I think so. I wanted to avoid linking to the driver with these changes.
rgsl888prabhu
approved these changes
Oct 7, 2025
Collaborator
|
/merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR enables stream concurrency by sharing SM resources between PDLP and Barrier. It fixes compile errors that occured while merging #272