Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ci/build_wheel_cuopt.sh
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@ EXCLUDE_ARGS=(
--exclude "libcusolver.so.*"
--exclude "libcusparse.so.*"
--exclude "libcuopt.so"
--exclude "libnvJitLink.so*"
--exclude "librapids_logger.so"
--exclude "librmm.so"
)
Expand Down
2 changes: 1 addition & 1 deletion ci/build_wheel_libcuopt.sh
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ EXCLUDE_ARGS=(
--exclude "libcusolver.so.*"
--exclude "libcusparse.so.*"
--exclude "libnccl.so.*"
--exclude "libnvJitLink*"
--exclude "libnvJitLink.so*"

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The .so was dropped from this line in #507, I think because of a misunderstanding of the order things happened in these builds.

auditwheel repair will take a dependency on libnvJitLink.so.13.3.33 and vendor in a library renamed like cuopt_cu13.libs/libnvJitLink-3ba1e744.so.13.3.33.

But this --exclude is matched against the DT_NEEDED entries in the .so files in the wheel, not against the names auditwheel creates afterwards.

So I think we really do want .so here, to avoid accidentally matching an (unlikely, but possible) other file named like libnvJitLink-cuopt-wrapper.so or something.

--exclude "librapids_logger.so"
--exclude "librmm.so"
# OpenSSL 3 is intentionally NOT bundled. Resolving libssl.so.3 / libcrypto.so.3
Expand Down
2 changes: 1 addition & 1 deletion python/cuopt/pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ select = [
]

# PyPI hard limit is 1GiB, but try to keep this as small as possible
max_allowed_size_compressed = '55Mi'
max_allowed_size_compressed = '10Mi'

[tool.pytest.ini_options]
testpaths = ["cuopt/tests"]
Expand Down
Loading