ensure nightly builds always produce new packages - #1661
Conversation
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
|
/ok to test |
|
/ok to test |
CI Test Summary✅ All 31 test job(s) passed. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe workflows now generate one ChangesBuild timestamp propagation
Job queue version parsing
Estimated code review effort: 2 (Simple) | ~10 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
| logging.debug(f"client_vers is {client_vers} in check") | ||
| if os.environ.get("CUOPT_CHECK_CLIENT", True) in ["True", True]: | ||
| major, minor, _ = __version__.split(".") | ||
| major, minor, *_ = __version__.split(".") |
There was a problem hiding this comment.
cuopt server tests were failing like this:
File "/pyenv/versions/3.12.13/lib/python3.12/site-packages/cuopt_server/utils/job_queue.py", line 54, in check_client_version
major, minor, _ = __version__.split(".")
^^^^^^^^^^^^^^^
ValueError: too many values to unpack (expected 3)
This PR now adds a 4th component to nightly versions (e.g. 26.10.0a14.post260807023309).
Since this code only cares about the first 2 components (major and minor), just throwing away the others with * seems defensible.
I looked for other patterns like this in the codebase and didn't see any.
|
/merge |
One conflict in the conda recipe: main renamed date_string to datetime_string (#1661) in the same block where this branch replaced the prefix_detection entry for libcuopt.so with the component libraries. Both changes kept. Build clean, ctest 125/125, check_symbols passes on all four components. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Signed-off-by: Ramakrishna Prabhu <ramakrishnap@nvidia.com>
Contributes to rapidsai/build-planning#218
For wheels:
And for conda:
Notes for Reviewers
How I tested this
See rapidsai/cugraph-gnn#508