Minimize Ubuntu Boost dependencies - #1165
Conversation
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
📝 WalkthroughWalkthroughThe Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
4eb9f46 to
e69f157
Compare
|
/ok to test |
jameslamb
left a comment
There was a problem hiding this comment.
Love this, thanks!
I just merged latest main in here to trigger a new CI run. Hopefully things will go better now that the *.ubuntu.com servers are somewhat stabilizing (https://status.canonical.com/).
|
/merge |
## Summary - install only the Boost components needed by cuOpt's PaPILO dependency on Ubuntu - add `libboost-iostreams-dev` and `libboost-serialization-dev` explicitly rather than `libboost-dev` - skip `libboost-program-options-dev` -- this is optional and not needed for PaPILO with the options we provide (`PAPILO_NO_BINARIES=ON`) Authors: - Bradley Dice (https://github.com/bdice) - James Lamb (https://github.com/jameslamb) - Miles Lubin (https://github.com/mlubin) Approvers: - James Lamb (https://github.com/jameslamb) URL: NVIDIA#1165
Summary
libboost-iostreams-devandlibboost-serialization-devexplicitly rather thanlibboost-devlibboost-program-options-dev-- this is optional and not needed for PaPILO with the options we provide (PAPILO_NO_BINARIES=ON)