cuda.core: Change selected .decode() calls to .decode("utf-8", errors="backslashreplace")

[rwgk]

Change selected .decode() calls to .decode("utf-8", errors="backslashreplace"), to avoid UnicodeDecodeError exceptions when converting error messages or program logs.

Fixes this error (when testing under Windows):

if _nvjitlink:
    log_size = _nvjitlink.get_error_log_size(self._mnff.handle)
    log = bytearray(log_size)
    _nvjitlink.get_error_log(self._mnff.handle, log)
else:
    log = self._options.formatted_options[2]
>   return log.decode()
E UnicodeDecodeError: 'utf-8' codec can't decode byte 0xaa in position 47: invalid start byte

Only the two changes in _linker.py are covered by existing unit tests, and only with valid utf-8 strings. I.e. the conditions for which this PR makes a difference are not actually exercised. — Making the test coverage more complete is left for later.

The selection in based on a manual review of all .decode() calls under cuda_core:

$ git grep 'decode('
cuda/core/experimental/_device.py:        return bus_id[:12].decode()
cuda/core/experimental/_device.py:        return name.decode()
cuda/core/experimental/_linker.py:        return log.decode("utf-8", errors="backslashreplace")
cuda/core/experimental/_linker.py:        return log.decode("utf-8", errors="backslashreplace")
cuda/core/experimental/_program.py:                    logs.write(log.decode("utf-8", errors="backslashreplace"))
cuda/core/experimental/_utils/cuda_utils.py:            raise CUDAError(f"{name.decode()}: {desc.decode()}")
cuda/core/experimental/_utils/cuda_utils.py:            raise CUDAError(f"{name.decode()}: {desc.decode()}")
cuda/core/experimental/_utils/cuda_utils.py:        err = f"{error}: {nvrtc.nvrtcGetErrorString(error)[1].decode()}"
cuda/core/experimental/_utils/cuda_utils.py:            err += f", compilation log:\n\n{log.decode('utf-8', errors='backslashreplace')}"
tests/test_device.py:    assert device.pci_bus_id == bus_id[:12].decode()
tests/test_device.py:    assert device.name == name.decode()
tests/test_program.py:    program = Program(ptx_code_object._module.decode(), "ptx", options=options)
tests/test_program.py:    program = Program(ptx_object_code._module.decode(), "ptx")

[copy-pr-bot]

Auto-sync is disabled for ready for review pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

[rwgk]

/ok to test

[rwgk]

Thanks @ksimpson-work, I'll merge this now, to support QA testing.

[github-actions]

Doc Preview CI
Preview removed because the pull request was closed or merged.