device properties#409
Merged
Merged
Conversation
Contributor
Contributor
Author
|
/ok to test |
keenan-simpson
added
enhancement
This comment has been minimized.
This comment has been minimized.
keenan-simpson
commented
Jan 23, 2025
|
|
||
|
|
||
| # ruff: noqa | ||
| class DeviceProperties: |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
carterbox
reviewed
Jan 23, 2025
rwgk
reviewed
Jan 27, 2025
| def __init__(self): | ||
| raise RuntimeError("DeviceProperties should not be instantiated directly") | ||
|
|
||
| slots = "_handle" |
Contributor
There was a problem hiding this comment.
bug fix: __slots__
(I discovered that via the suggested added test.)
Contributor
Author
|
Thanks for your review @rwgk . Notable improvements :) |
Contributor
Author
|
/ok to test |
Contributor
Author
|
/ok to test |
Contributor
Author
|
/ok to test |
Contributor
Author
|
previous run encounter CI runner issue on one test. re-running the CI. |
Merged
Contributor
Author
|
/ok to test |
Contributor
Author
|
@leofang this one should be good to go. Ralf has approved but I wanted to make sure you were ok with it |
leofang
requested changes
Feb 14, 2025
leofang
requested changes
Feb 14, 2025
Member
leofang
left a comment
leofang
left a comment
There was a problem hiding this comment.
there are in total 5 dynamic attributes that we should not cache
Contributor
Author
|
/ok to test |
rwgk
approved these changes
Feb 14, 2025
Contributor
rwgk
left a comment
rwgk
left a comment
There was a problem hiding this comment.
The new commit looks good to me.
Member
|
CI is green, let me merge. |
Member
|
Thanks a lot, Keenan, Ralf, Daniel! |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close #210