handle CTK version specific options in the linker test#371
Merged
keenan-simpson merged 23 commits intoFeb 3, 2025
Conversation
Contributor
keenan-simpson
added
P1
Contributor
Author
|
/ok to test |
Merged
Contributor
Author
|
/ok to test |
leofang
reviewed
Jan 15, 2025
leofang
reviewed
Jan 15, 2025
leofang
reviewed
Jan 15, 2025
Co-authored-by: Leo Fang <leof@nvidia.com>
Contributor
Author
|
/ok to test |
Contributor
Author
|
/ok to test |
Contributor
Author
|
/ok to test |
Contributor
Author
|
/ok to test |
This comment has been minimized.
This comment has been minimized.
Contributor
|
I looked. I'll ping @ksimpson-work to chat 1:1. |
keenan-simpson
commented
Jan 17, 2025
… into handle-version-specific-options
keenan-simpson
changed the title
Contributor
Author
|
/ok to test |
… into handle-version-specific-options
Contributor
Author
|
/ok to test |
leofang
reviewed
Jan 23, 2025
Contributor
Author
|
/ok to test |
rwgk
previously approved these changes
Jan 28, 2025
Contributor
rwgk
left a comment
rwgk
left a comment
There was a problem hiding this comment.
This looks great to me. (When I looked before the weekend I saw a CI error but it looked unrelated. Is it gone now?)
| LinkerOptions(arch=ARCH, no_cache=True), # TODO: consider adding cuda 12.4 to test matrix in which case this | ||
| # will fail. Tracked in issue #337 | ||
| ] | ||
| if not culink_backend: |
Contributor
There was a problem hiding this comment.
Suggested for line 22 above:
if culink_backend:
nvjitlink = None
else:
from cuda.bindings import nvjitlink
Then here:
if nvjitlink is not None:
That way the import appears only once, and near the top, where it is more expected.
| # | ||
| # SPDX-License-Identifier: LicenseRef-NVIDIA-SOFTWARE-LICENSE | ||
|
|
||
|
|
Contributor
There was a problem hiding this comment.
Delete the extra empty line again?
Contributor
Author
|
/ok to test |
rwgk
approved these changes
Jan 28, 2025
Contributor
Author
|
/ok to test |
Contributor
Author
|
/ok to test |
1 similar comment
Contributor
Author
|
/ok to test |
Contributor
Author
|
/ok to test |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change skips tests when a specific nvjitlink exception is raised for invalid option, which happens if the option is invalid, or if the option is invalid for the given CTK.
I think we should also add cuda 12.4 to the test matrix because <21.3 targets the culink backend, and cuda 12.6 has options which aren't part of 12.4