switch the launch argument order#316
Merged
Merged
Conversation
keenan-simpson
added
P0
Contributor
Member
|
/ok to test |
Contributor
Author
|
/ok to test |
Member
|
Let's hold off merging for now. We need to wait for Bryce's update on the kernel spec. |
Contributor
Author
|
/ok to test |
This comment has been minimized.
This comment has been minimized.
Member
|
This comment was marked as resolved.
This comment was marked as resolved.
leofang
added
triage
leofang
added
P0
Member
|
Update: Discussed with Bryce and Keith offline, we want to get this PR included in beta 3. |
Member
|
/ok to test |
leofang
reviewed
Feb 27, 2025
leofang
requested changes
Mar 1, 2025
Member
leofang
left a comment
leofang
left a comment
There was a problem hiding this comment.
The remaining code examples also need update.
Member
|
/ok to test |
Member
|
TODO: Finalize the discussion on if we also want to pull out |
Contributor
|
/ok to test |
leofang
requested changes
Mar 3, 2025
Member
leofang
left a comment
leofang
left a comment
There was a problem hiding this comment.
LGTM overall, thanks Vlad! Let's get the test part covered.
Contributor
|
/ok to test |
leofang
approved these changes
Mar 3, 2025
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close #306
flip the launch args