This repository was archived by the owner on Mar 21, 2024. It is now read-only.
Fix device-side reduce launch with large inputs#597
Merged
gevtushenko merged 1 commit intoNov 25, 2022
Merged
Conversation
miscco
approved these changes
Nov 25, 2022
elstehle
approved these changes
Nov 25, 2022
elstehle
left a comment
Collaborator
There was a problem hiding this comment.
Interesting finding 👍
Seems a bit concerning that device-side triple_chevron::do_it isn't type safe. Could imagine that one can easily instantiate a kernel template for different parameter types then are eventually getting passed to the kernel invocation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When there are more than one tile of input items, we launch two kernels for reduction. During the second kernel launch, we accumulate partial aggregates from thread blocks. In this case,
int reduce_grid_sizeis passed toOffsetT num_itemskernel parameter. Thrusttriple_chevronis not type safe when used on device. These facts lead to a mismatch of data size we put into a param buffer (4 bytes) and that the kernel reads from the buffer (8 bytes). This seems to be a bug that was long present in thrust, that uses dispatch layer directly with offset types different fromint32_t. In the case of host-side usage, type conversion takes place, leading to normal execution.