Skip to content

Add NICo node maintenance validation - #574

Draft
osu wants to merge 1 commit into
NVIDIA:mainfrom
osu:issue-207-nico-node-maintenance
Draft

Add NICo node maintenance validation#574
osu wants to merge 1 commit into
NVIDIA:mainfrom
osu:issue-207-nico-node-maintenance

Conversation

@osu

@osu osu commented Aug 9, 2026

Copy link
Copy Markdown
Member

Summary

  • replace the BFX01-02 NICo gap stub with a real Machine maintenance-mode cycle
  • require an explicit dedicated Machine ID and a separate mutation opt-in; default runs remain read-only structured skips
  • reject machines that are not Ready, belong to another Site, or are allocated
  • request maintenance through NICo, verify the Machine reaches Maintenance, and always disable maintenance mode in finally
  • verify the fixture returns exactly to its initial Ready state before reporting success
  • strengthen ReturnNodeMaintenanceCheck so fabricated accepted: true output cannot pass without request, state, and restoration evidence

Safety

This is staging-only and mutating. It runs only when both are set:

  • NICO_BREAKFIX_MACHINE_ID=<dedicated-fixture-id>
  • NICO_BREAKFIX_ALLOW_MUTATION=1

No Machine is selected automatically. The orchestration timeout allows the cleanup path to finish.

Closes #207.

Validation

  • uv run pytest -q isvctl/tests/providers/nico/test_nico_provider.py isvtest/tests/test_breakfix.py (199 passed)
  • all my-isv demo suites passed
  • NICo configuration and suite wiring validation passed
  • applicable pre-commit hooks passed
  • default live invocation against dev3 returned the intended read-only fixture-required runtime skip

No live maintenance mutation was run because the six visible dev3 Machines are not identified as dedicated/reserved validation fixtures.

Signed-off-by: Hasan Khan <hasank@nvidia.com>
@copy-pr-bot

copy-pr-bot Bot commented Aug 9, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@coderabbitai

coderabbitai Bot commented Aug 9, 2026

Copy link
Copy Markdown

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 0c66e368-4a31-4b1e-99b7-423cd9b2db32

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BFX01-02: Return an individual node to the provider for maintenance via the API

1 participant