Add NICo node maintenance validation - #574
Draft
osu wants to merge 1 commit into
Draft
Conversation
Signed-off-by: Hasan Khan <hasank@nvidia.com>
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ready, belong to another Site, or are allocatedMaintenance, and always disable maintenance mode infinallyReadystate before reporting successReturnNodeMaintenanceCheckso fabricatedaccepted: trueoutput cannot pass without request, state, and restoration evidenceSafety
This is staging-only and mutating. It runs only when both are set:
NICO_BREAKFIX_MACHINE_ID=<dedicated-fixture-id>NICO_BREAKFIX_ALLOW_MUTATION=1No Machine is selected automatically. The orchestration timeout allows the cleanup path to finish.
Closes #207.
Validation
uv run pytest -q isvctl/tests/providers/nico/test_nico_provider.py isvtest/tests/test_breakfix.py(199 passed)my-isvdemo suites passedNo live maintenance mutation was run because the six visible dev3 Machines are not identified as dedicated/reserved validation fixtures.