Skip to content

Add NICo NVSwitch firmware query - #573

Draft
osu wants to merge 2 commits into
NVIDIA:mainfrom
osu:issue-214-nv-switch-firmware
Draft

Add NICo NVSwitch firmware query#573
osu wants to merge 2 commits into
NVIDIA:mainfrom
osu:issue-214-nv-switch-firmware

Conversation

@osu

@osu osu commented Aug 9, 2026

Copy link
Copy Markdown
Member

Summary

  • replace the BFX03-02 NICo gap stub with the read-only tray inventory API
  • query every paginated tray and filter NVSwitch types client-side so both deployed and current API enum spellings are supported
  • map every NVSwitch tray to the provider-neutral tray_id / firmware_version contract
  • preserve missing firmware values so incomplete inventory fails visibly
  • emit a structured BFX03-02 runtime skip only for the exact NICo 412 Site does not have NICo Flow enabled response

Why

NICo exposes NVSwitch tray firmware through its Flow-backed tray inventory. Available DSX staging sites currently have Flow disabled, so the provider must distinguish an unavailable site capability from an implementation failure without reporting false success.

Closes #214.

Validation

  • uv run pytest -q isvctl/tests/providers/nico/test_nico_provider.py isvtest/tests/test_breakfix.py (191 passed)
  • uv run isvctl test validate -f isvctl/configs/providers/nico/config/bare_metal.yaml
  • applicable pre-commit hooks passed
  • live read-only NICo execution on az51-dev3 and az51-dev4-dh1 returned the expected structured BFX03-02 runtime skip because both sites report Flow disabled
  • no cluster state was changed

A live positive result still requires a Flow-enabled staging site with NVSwitch trays.

Signed-off-by: Hasan Khan <hasank@nvidia.com>
@copy-pr-bot

copy-pr-bot Bot commented Aug 9, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@coderabbitai

coderabbitai Bot commented Aug 9, 2026

Copy link
Copy Markdown

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 4aa5035a-ff1c-470f-8c94-26281a22880a

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@osu

osu commented Aug 9, 2026

Copy link
Copy Markdown
Member Author

Closing after live NICo validation. The read-only rack endpoint returned 412 Site does not have NICo Flow enabled on both az51-dev3 and az51-dev4-dh1; the tray endpoint with type=NVLSwitch returned the same result on dev3. Since the platform feature is not enabled in the available validation environments, we should retain the existing BFX03-02 gap stub rather than add an untestable ISV implementation. No cluster state was changed.

@osu osu closed this Aug 9, 2026
Signed-off-by: Hasan Khan <hasank@nvidia.com>
@osu osu reopened this Aug 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BFX03-02: Inspect firmware versions of NV switch trays

1 participant