Repository navigation
Conversation
Signed-off-by: yifeif <277870278+yifeif-nv@users.noreply.github.com>
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Comment |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
The family isolation refactor removed the model detail page's configuration and command reference, and the Supported Models table now renders checkpoint and family names as plain text. Users cannot inspect the settings behind a listed model.
Exit Criteria
Every listed family and checkpoint recipe opens a detail page with its current parameters, defaults, restrictions, source references, and explicitly scoped verification results.
Implementation
Change categories
Validation
Commands and Results
npm --prefix website run test:model-supportunder Node 20.20.2: 18 Node tests and 21 Python tests passed, including complete current-family/recipe coverage and adversarial extraction cases.npm --prefix website run buildunder Node 20.20.2: passed, including 34 diagrams and rendered links/configuration checks for 135 families, 303 recipes, and 31 tasks.PYTHONPATH=core/builder:apps/benchmark:. python3 -m tools.model_ci validate: passed for all 135 families.PYTHONPATH=core/builder:apps/benchmark:. python3 -m pytest core/builder/tests/test_family_cli.py core/builder/tests/test_build_cli.py -q: 63 passed.git diff --check: passed.Hardware, Environment, and Revisions
The validated website changes are committed as
9ad9d51ffbaac6ab4cd24352090e26ad2586fcd4, based on audited family source383271563a10dfacaf1360ded8ec8a59f7ce7dbe. Local validation used Linux/aarch64, Python 3.12.3 and Node 20.20.2 with the existing website lockfile. GPU, CUDA and TensorRT were not used. Checkpoint revisions are preserved from each manifest; checkpoint weights were not downloaded.Not Run / Remaining Gaps
TensorRT builds, native runtime configuration acceptance, GPU execution, parity, and performance were not run. The two build-input discrepancies and fourteen incomplete benchmark request mappings are described below and shown on the affected pages. Required remote premerge has not been established; this is a draft PR.
Contributor Self-Review
Reviewed the complete website-only diff, historical behavior, parser/control-flow edge cases, generated HTML coverage, and browser behavior. No family implementation or test threshold changes are included.
Notes For Future Readers
Start with the inventory plugin, then the extraction scripts and parameter renderer. The new reference contains 783 configuration declarations. Three families have no extracted typed configuration declaration; their actual build request, manifest, restrictions, and source links remain available.
Of 303 recipes, 301 pass the limited build-input checks. Two existing boundaries are shown on their pages:
sam-vit-base-tp4declares amax_sequence_lengthrejected by its family, andsam2-public-core-l0usesmixed_bf16_fp32, accepted by its Python request but not expressible through the standard CLI precision choices. No family implementation or test passing criteria were changed.Of 386 testcase requests, 372 map through the current CPU benchmark adapters. Seven need an adapter and seven Parakeet probes need family fixture preparation. These incomplete mappings are not model-support failures.
Risk level
The change affects documentation generation and navigation. Configuration extraction remains scoped source/CPU evidence, preserves complete source declarations for complex cases, and does not change model runtime behavior.