Skip to content

chore(helm): remove unused ClusterRole and ClusterRoleBinding#943

Merged
TaylorMutch merged 2 commits into
mainfrom
tmutch/remove-unused-clusterrole
Apr 23, 2026
Merged

chore(helm): remove unused ClusterRole and ClusterRoleBinding#943
TaylorMutch merged 2 commits into
mainfrom
tmutch/remove-unused-clusterrole

Conversation

@TaylorMutch
Copy link
Copy Markdown
Collaborator

Summary

Removes the unused ClusterRole and ClusterRoleBinding from the Helm chart. These resources granted read access to runtimeclasses and nodes, but are not required by the OpenShell gateway.

Related Issue

N/A

Changes

  • Deleted deploy/helm/openshell/templates/clusterrole.yaml
  • Deleted deploy/helm/openshell/templates/clusterrolebinding.yaml

Testing

  • mise run pre-commit passes
  • Unit tests added/updated
  • E2E tests added/updated (if applicable)

Checklist

  • Follows Conventional Commits
  • Commits are signed off (DCO)
  • Architecture docs updated (if applicable)

@copy-pr-bot
Copy link
Copy Markdown

copy-pr-bot Bot commented Apr 23, 2026

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@TaylorMutch TaylorMutch added the test:e2e Requires end-to-end coverage label Apr 23, 2026
@TaylorMutch
Copy link
Copy Markdown
Collaborator Author

/ok-to-test ef4cb6e

@TaylorMutch TaylorMutch marked this pull request as ready for review April 23, 2026 19:32
@TaylorMutch TaylorMutch requested a review from a team as a code owner April 23, 2026 19:32
@pimlock
Copy link
Copy Markdown
Collaborator

pimlock commented Apr 23, 2026

/ok to test 3e35237

@TaylorMutch TaylorMutch merged commit 550c6e4 into main Apr 23, 2026
21 of 24 checks passed
@TaylorMutch TaylorMutch deleted the tmutch/remove-unused-clusterrole branch April 23, 2026 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

test:e2e Requires end-to-end coverage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants