fix(driver-mxc): implement authenticate_sandbox trait method - #3158
Merged
pimlock merged 1 commit intoSep 3, 2026
Merged
Conversation
Closes NVIDIA#3155 Add the missing authenticate_sandbox method to the ComputeDriver impl for the MXC driver. The method returns Status::unimplemented, matching the Docker and Podman drivers, since the MXC driver advertises supports_sandbox_authentication: false. Signed-off-by: Jeff MAURY <jmaury@nvidia.com> Signed-off-by: Jeff MAURY <jmaury@redhat.com>
jeffmaury
requested review from
a team,
derekwaynecarr,
mrunalp and
sjenning
as code owners
September 3, 2026 14:39
3 tasks
johntmyers
approved these changes
Sep 3, 2026
Collaborator
|
/ok to test 59d9d57 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add the missing
authenticate_sandboxmethod to the MXC driver'sComputeDriverimpl, fixing the compilation error introduced by commit 9b6d904. The method returnsStatus::unimplemented, matching the Docker and Podman drivers, since the MXC driver advertisessupports_sandbox_authentication: false.Related Issue
Closes #3155
Changes
crates/openshell-driver-mxc/src/grpc.rs: AddedAuthenticateSandboxRequest/AuthenticateSandboxResponseimports and implementedauthenticate_sandboxreturningStatus::unimplemented("mxc does not authenticate sandbox credentials")Deviations from Plan
None — implemented as planned. The
supports_sandbox_authenticationfield indriver.rswas already present (set tofalse), so only the trait method ingrpc.rsneeded adding.Testing
mise run pre-commitpasses (proto:lint failure is pre-existing Windows env issue)cargo check -p openshell-driver-mxccompiles cleanlycargo test -p openshell-driver-mxc— all 75 tests pass (27 unit + 48 integration, 9 ignored as expected)Tests added:
Checklist
Documentation updated: