fix(policy): ignore advisor provenance during contract inference - #3069
Merged
Conversation
Signed-off-by: Piotr Mlocek <pmlocek@nvidia.com>
johntmyers
requested review from
a team,
derekwaynecarr,
mrunalp and
sjenning
as code owners
September 1, 2026 01:27
Signed-off-by: John Myers <johntmyers@users.noreply.github.com>
johntmyers
force-pushed
the
fix-advisor-provenance-contract/johntmyers
branch
from
September 1, 2026 14:52
9758f2d to
7166ac0
Compare
Signed-off-by: John Myers <johntmyers@users.noreply.github.com>
pimlock
approved these changes
Sep 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Prevent policy-advisor contract inference from treating otherwise identical endpoints as distinct solely because one endpoint carries advisor provenance. This fixes the late follow-up identified on #2935, where a subsequent mechanistic proposal could be stored with an application error instead of being auto-approved.
Related Issue
No issue required: localized regression follow-up to #2935 and review comment.
Changes
provider_credentialedandadvisor_proposedprovenance while deduplicating effective endpoint contracts.Testing
mise run pre-commitpassescargo test -p openshell-policypasses (236 tests)Checklist