feat(supervisor): expose sandbox name to middleware request context - #2771
Merged
pimlock merged 2 commits intoAug 21, 2026
Merged
Conversation
letv1nnn
requested review from
a team,
derekwaynecarr,
mrunalp and
sjenning
as code owners
August 17, 2026 10:14
pimlock
reviewed
Aug 20, 2026
letv1nnn
force-pushed
the
expose-sandbox-name-to-supervisor-middleware
branch
from
August 20, 2026 13:07
9d38ccf to
803dc62
Compare
14 tasks
pimlock
reviewed
Aug 20, 2026
pimlock
reviewed
Aug 20, 2026
pimlock
left a comment
Collaborator
There was a problem hiding this comment.
Thanks! This looks good now, just one small comment for the documentation update.
letv1nnn
force-pushed
the
expose-sandbox-name-to-supervisor-middleware
branch
from
August 21, 2026 09:29
803dc62 to
7ce3d62
Compare
Collaborator
|
/ok to test 7ce3d62 |
pimlock
previously approved these changes
Aug 21, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Aug 21, 2026
Collaborator
|
@letv1nnn looks like the change doesn't build on main (https://github.com/NVIDIA/OpenShell/actions/runs/32503624769/job/96838754570), due to some recent changes needing to handle the extra params. Please rebase your branch on main, update any new code and this should be good to go. Thanks! |
Signed-off-by: Artem Lytvyn <alytvyn@redhat.com>
letv1nnn
force-pushed
the
expose-sandbox-name-to-supervisor-middleware
branch
from
August 21, 2026 17:31
7ce3d62 to
89af438
Compare
Collaborator
|
/ok to test 89af438 |
Signed-off-by: Artem Lytvyn <alytvyn@redhat.com>
letv1nnn
force-pushed
the
expose-sandbox-name-to-supervisor-middleware
branch
from
August 21, 2026 18:05
89af438 to
244935e
Compare
Contributor
Author
|
@pimlock, rebased onto latest main and fixed the transparent-TCP |
Collaborator
|
/ok to test 244935e |
pimlock
approved these changes
Aug 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the originating sandbox name to the supervisor middleware request context. Operator-run middleware already receives the sandbox ID; passing the name alongside it lets audit and approval interfaces show a human-readable identifier instead of an opaque UUID, using data the supervisor already owns.
Related Issue
Closes #2754
Changes
sandbox_namefield toRequestContextinproto/supervisor_middleware.proto; existing field numbers are unchanged for wire compatibility.sandbox_nametoopenshell_supervisor_middleware::HttpRequestInputand carry it into the gRPCRequestContext.sandbox_idandsandbox_namefrom the process-wideopenshell_ocsf::SandboxContextwhen the network supervisor builds middleware input.SandboxContextintomiddleware_request_inputinstead of reading the global inside it, making the identifier copy unit-testable with a real name.docs/extensibility/supervisor-middleware.mdx.#[cfg(target_os = "linux")]gate on thestd::path::Pathimport inopenshell-driver-podman'scontainer.rs.Pathis used unconditionally in a public function signature, so the gated import broke the non-Linux (macOS) build after mergingmain. Unrelated to the feature but required for the branch to compile cross-platform.Testing
mise run pre-commitpassesChecklist