Skip to content

test(kubernetes): add optional Envoy-backed e2e mode #2259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
elezar wants to merge 2 commits into
base: main
Choose a base branch
from
+304 −61
Open

test(kubernetes): add optional Envoy-backed e2e mode #2259

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d5fbc67
test(kubernetes): add safe Envoy-backed e2e mode
elezar Jul 14, 2026
9b5c53e
ci(kubernetes): expose Envoy Gateway e2e input
elezar Jul 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions .github/workflows/branch-e2e.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,14 +157,22 @@ jobs:
agent_sandbox_version: v0.5.0
topology: combined
extra_helm_values: ""
use_envoy_gateway: false
- agent_sandbox_api: v1alpha1
agent_sandbox_version: v0.4.6
topology: combined
extra_helm_values: ""
use_envoy_gateway: false
- agent_sandbox_api: v1beta1
agent_sandbox_version: v0.5.0
topology: sidecar
extra_helm_values: deploy/helm/openshell/ci/values-sidecar.yaml
use_envoy_gateway: false
- agent_sandbox_api: v1beta1
agent_sandbox_version: v0.5.0
topology: envoy
extra_helm_values: ""
use_envoy_gateway: true
permissions:
actions: read
contents: read
Expand All @@ -175,6 +183,7 @@ jobs:
job-name: Kubernetes E2E (Rust smoke, ${{ matrix.topology }}, Agent Sandbox ${{ matrix.agent_sandbox_api }})
agent-sandbox-version: ${{ matrix.agent_sandbox_version }}
extra-helm-values: ${{ matrix.extra_helm_values }}
use-envoy-gateway: ${{ matrix.use_envoy_gateway }}
cli-artifact-prefix: rust-binary-cli

kubernetes-ha-e2e:
Expand Down
8 changes: 8 additions & 0 deletions .github/workflows/e2e-kubernetes-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,13 @@ on:
required: false
type: string
default: "v0.5.0"
# This keeps the standard single-replica deployment and validates the
# Gateway API/Envoy GRPCRoute path. It does not enable HA.
use-envoy-gateway:
description: "Exercise Gateway API/Envoy routing for the standard single-replica e2e suite"
required: false
type: boolean
default: false
Comment on lines +42 to +46

@drew drew Jul 27, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the motivation for this? Is it to make sure we can test HA deployments?

@elezar elezar Jul 28, 2026 •
edited
Loading

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The primary motivation for this PR (and some of the others) was to reduce the surface of #1868 (adding HA support) somewhat. This includes adding Envoy configuration / deployments to provide a stable endpoint for the HA case.

As reviewed, the PR added the option but didn't actually exercise any of the added functionality. Since using Envoy is a separate from an HA deployment, I have updated the PR to add an "envoy-enabled" path to the existing tests. This should mean that we can shake out any issues with the envoy-gateway interaction separately from the HA functionality.

Depending on the load on CI, we can consider removing it again or simplifying our test matrix for k8s once HA support lands.

mise-version:
description: "mise version to install on the bare Kubernetes e2e runner"
required: false
Expand Down Expand Up @@ -136,6 +143,7 @@ jobs:
OPENSHELL_E2E_KUBE_CONTEXT: kind-${{ env.KIND_CLUSTER_NAME }}
OPENSHELL_E2E_KUBE_EXTRA_VALUES: ${{ inputs.extra-helm-values }}
OPENSHELL_E2E_KUBE_EXTERNAL_POSTGRES_SECRET: ${{ inputs.external-postgres-secret }}
OPENSHELL_E2E_KUBE_USE_ENVOY: ${{ inputs.use-envoy-gateway }}
IMAGE_TAG: ${{ inputs.image-tag }}
OPENSHELL_REGISTRY: ghcr.io/nvidia/openshell
run: mise run --no-deps --skip-deps e2e:kubernetes
Loading
Loading