fix(tui): use correct ssh-proxy CLI args in shell connect and exec - #193
Merged
Conversation
The ProxyCommand in handle_shell_connect and handle_exec_command was using --gateway for the URL, but after the #175 rename --gateway means cluster name and --gateway-endpoint is the URL flag. The ssh-proxy subprocess could not match token mode (no --gateway-endpoint) or name mode (no --name), so it exited immediately — causing a screen flash and eventual terminal corruption from rapid suspend/resume cycles. Use --gateway-endpoint for the URL and --gateway for the cluster name, matching the format already used by start_port_forwards and the CLI. Fixes #188
drew
pushed a commit
that referenced
this pull request
Mar 16, 2026
) The ProxyCommand in handle_shell_connect and handle_exec_command was using --gateway for the URL, but after the #175 rename --gateway means cluster name and --gateway-endpoint is the URL flag. The ssh-proxy subprocess could not match token mode (no --gateway-endpoint) or name mode (no --name), so it exited immediately — causing a screen flash and eventual terminal corruption from rapid suspend/resume cycles. Use --gateway-endpoint for the URL and --gateway for the cluster name, matching the format already used by start_port_forwards and the CLI. Fixes #188 Co-authored-by: John Myers <johntmyers@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #188
Summary
handle_shell_connectandhandle_exec_commandwere using--gateway(cluster name flag) to pass the gateway URL, and omitting the cluster name entirely. After the--gateway→--gateway-endpointrename in feat(cli): improve sandbox provisioning status messages and UX #175, this causedssh-proxyto fail immediately — producing the flash-and-return behavior and eventual terminal corruption.--gateway-endpointfor the URL and--gatewayfor the cluster name, matching the format already used bystart_port_forwardsand the CLI'sssh_session_config.Test Plan
[s]on a sandbox, shell session connected successfully.mise run pre-commitpasses (all tests, clippy, fmt).