Skip to content

test(sandbox): cover inference stream truncation SSE errors#1418

Merged
TaylorMutch merged 1 commit into
NVIDIA:mainfrom
mjamiv:fix/inference-stream-sse-error-tests
May 18, 2026
Merged

test(sandbox): cover inference stream truncation SSE errors#1418
TaylorMutch merged 1 commit into
NVIDIA:mainfrom
mjamiv:fix/inference-stream-sse-error-tests

Conversation

@mjamiv
Copy link
Copy Markdown
Contributor

@mjamiv mjamiv commented May 17, 2026

Summary

Closes #846.

Validation

  • cargo fmt --all -- --check
  • cargo test -p openshell-sandbox inference_stream_ -- --nocapture
  • cargo test -p openshell-sandbox
  • cargo clippy -p openshell-sandbox --all-targets -- -D warnings

@mjamiv mjamiv requested review from a team, derekwaynecarr, maxamillion and mrunalp as code owners May 17, 2026 14:35
@copy-pr-bot
Copy link
Copy Markdown

copy-pr-bot Bot commented May 17, 2026

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@TaylorMutch TaylorMutch self-assigned this May 18, 2026
@TaylorMutch TaylorMutch added the test:e2e Requires end-to-end coverage label May 18, 2026
@github-actions
Copy link
Copy Markdown

Label test:e2e applied, but pull-request/1418 is at {"messa while the PR head is c0a7e9f. A maintainer needs to comment /ok to test c0a7e9f0799db527630d6733744c2b436bf067e2 to refresh the mirror. Once the mirror catches up, re-run Branch E2E Checks from the Actions tab.

@TaylorMutch
Copy link
Copy Markdown
Collaborator

/ok to test c0a7e9f

Copy link
Copy Markdown
Collaborator

@TaylorMutch TaylorMutch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@TaylorMutch TaylorMutch merged commit a54758c into NVIDIA:main May 18, 2026
40 of 42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

test:e2e Requires end-to-end coverage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

inference proxy: no end-to-end test coverage for the three truncation → SSE-error paths in route_inference_request

2 participants