fix(ci): restore protobuf and helm build checks#1392
Closed
drew wants to merge 1 commit into
Closed
Conversation
Signed-off-by: Drew Newberry <anewberry@nvidia.com>
TaylorMutch
approved these changes
May 14, 2026
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Restore failing main build checks by making protobuf codegen find well-known proto includes after removing
protobuf-src, adding matching protobuf packages to macOS Docker and RPM build environments, and disabling Helm v4 plugin verification for the helm-unittest plugin install in the CI image.Related Issue
Related to #1387
Changes
openshell-corebuild codegen.--verify=falsefor the Helm unittest plugin install in the CI image.Testing
cargo fmt --checkRUSTC_WRAPPER= cargo check -p openshell-coreRUSTC_WRAPPER= cargo clippy -p openshell-core --all-targets -- -D warningsmise x -- helm plugin install --help | rg -n "verify"git diff --checkmise run pre-commitChecklist