Skip to content

fix(ci): restore protobuf and helm build checks#1392

Closed
drew wants to merge 1 commit into
mainfrom
1387-fix-main-checks/an
Closed

fix(ci): restore protobuf and helm build checks#1392
drew wants to merge 1 commit into
mainfrom
1387-fix-main-checks/an

Conversation

@drew
Copy link
Copy Markdown
Collaborator

@drew drew commented May 14, 2026

Summary

Restore failing main build checks by making protobuf codegen find well-known proto includes after removing protobuf-src, adding matching protobuf packages to macOS Docker and RPM build environments, and disabling Helm v4 plugin verification for the helm-unittest plugin install in the CI image.

Related Issue

Related to #1387

Changes

  • Add explicit well-known protobuf include detection to openshell-core build codegen.
  • Install protobuf development headers in macOS/Python Docker build images.
  • Add protobuf compiler/devel dependencies to RPM workflow and spec.
  • Pass --verify=false for the Helm unittest plugin install in the CI image.

Testing

  • cargo fmt --check
  • RUSTC_WRAPPER= cargo check -p openshell-core
  • RUSTC_WRAPPER= cargo clippy -p openshell-core --all-targets -- -D warnings
  • mise x -- helm plugin install --help | rg -n "verify"
  • git diff --check
  • mise run pre-commit

Checklist

  • Follows Conventional Commits
  • Commits are signed off (DCO)

Signed-off-by: Drew Newberry <anewberry@nvidia.com>
@drew drew requested review from a team, derekwaynecarr, maxamillion and mrunalp as code owners May 14, 2026 21:50
@drew drew marked this pull request as draft May 14, 2026 22:01
@copy-pr-bot
Copy link
Copy Markdown

copy-pr-bot Bot commented May 14, 2026

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@drew drew closed this May 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants