refactor(cli): remove gateway lifecycle management#1221
Merged
Conversation
drew
requested review from
a team,
derekwaynecarr,
maxamillion and
mrunalp
as code owners
|
🌿 Preview your docs: https://nvidia-preview-pr-1221.docs.buildwithfern.com/openshell |
TaylorMutch
previously approved these changes
May 6, 2026
Collaborator
|
and |
|
Label |
|
Label |
Signed-off-by: Drew Newberry <anewberry@nvidia.com>
Signed-off-by: Drew Newberry <anewberry@nvidia.com>
drew
force-pushed
the
remove-gateway-management
branch
from
b814313 to
0cb254f
Compare
3 tasks
rodbutters
added a commit
to iamaible/OpenShell
that referenced
this pull request
May 20, 2026
# Conflicts:
# crates/openshell-server/src/cli.rs
# deploy/docker/Dockerfile.gateway
# deploy/docker/Dockerfile.supervisor
# deploy/helm/openshell/values.yaml
fix(deploy): merge upstream, remove cluster image, parameterize registry
- Resolve merge conflicts from main merge:
- cli.rs: migrate Args -> Cli, UNSPECIFIED -> LOCALHOST to match upstream
- values.yaml: keep docker.io/aible registry and pinned tag, adopt
upstream doc comments for Helm docs generation
- Remove deprecated cluster image artifacts (Dockerfile.cluster,
cluster-entrypoint.sh, cluster-healthcheck.sh) following upstream
removal in PR NVIDIA#390 and full lifecycle deprecation in PR NVIDIA#1221
- Parameterize docker-build.yml with image-registry input (default:
ghcr.io/nvidia/openshell); fork callers pass docker.io/aible to route
builds to the aible registry; login step selects REGISTRY_TOKEN vs
GITHUB_TOKEN based on registry hostname
- Clean up docker-build-local.sh: remove cluster target, CLUSTER_IMAGE
and CLUSTER_BASE_IMAGE env vars, and build_cluster function
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove CLI-owned gateway service lifecycle commands and bootstrap fallback so package/systemd/Helm flows own gateway start/stop/destruction.
Related Issue
N/A
Changes
openshell gateway start|stop|destroy, sandbox auto-bootstrap fallback, and the old doctor LLM prompt.openshell gateway remove [name]for local registration cleanup.openshell-bootstrapto registration/auth/PKI/build helpers and removed Docker runtime/image push bootstrap code.Testing
mise run pre-commitpassesChecklist