Skip to content

fix: onboard fails on GPUs with insufficient VRAM for local NIM #836

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cv merged 2 commits into from
Mar 30, 2026
Merged

fix: onboard fails on GPUs with insufficient VRAM for local NIM #836

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f3bb753
fix: check GPU VRAM against NIM model requirements before setting nim…
cdeleeuw Mar 24, 2026
2b5603d
Merge branch 'main' into fix/nimcapable-vram-check
cv Mar 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion bin/lib/nim.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,12 +35,14 @@ function detectGpu() {
const perGpuMB = lines.map((l) => parseInt(l.trim(), 10)).filter((n) => !isNaN(n));
if (perGpuMB.length > 0) {
const totalMemoryMB = perGpuMB.reduce((a, b) => a + b, 0);
// Only mark nimCapable if at least one NIM model fits in GPU VRAM
const canRunNim = nimImages.models.some((m) => m.minGpuMemoryMB <= totalMemoryMB);
return {
type: "nvidia",
count: perGpuMB.length,
totalMemoryMB,
perGpuMB: perGpuMB[0],
nimCapable: true,
nimCapable: canRunNim,
};
}
}
Expand Down
3 changes: 3 additions & 0 deletions bin/lib/onboard.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1587,6 +1587,9 @@ async function preflight() {
const gpu = nim.detectGpu();
if (gpu && gpu.type === "nvidia") {
console.log(` ✓ NVIDIA GPU detected: ${gpu.count} GPU(s), ${gpu.totalMemoryMB} MB VRAM`);
if (!gpu.nimCapable) {
console.log(" ⓘ GPU VRAM too small for local NIM — will use cloud inference");
}
} else if (gpu && gpu.type === "apple") {
console.log(` ✓ Apple GPU detected: ${gpu.name}${gpu.cores ? ` (${gpu.cores} cores)` : ""}, ${gpu.totalMemoryMB} MB unified memory`);
console.log(" ⓘ NIM requires NVIDIA GPU — will use cloud inference");
Expand Down