fix(onboarding): suppress credential prompt interrupt stack

[senthilr-nv]

Summary

Ctrl+C at a hidden onboarding credential prompt now completes through the existing SIGINT handler. The CLI keeps resumable-session guidance and status 130 without printing Error: Prompt interrupted or a Node.js stack.

Related Issue

Fixes #7439

Changes

• Treat a prompt rejection with code SIGINT as cancellation at the onboarding command boundary. The prompt still restores terminal state and re-raises SIGINT, and the onboarding exit handler still records the resumable step.
• Add a source regression for the command boundary.
• Add compiled-package regressions for direct hidden-prompt cancellation and the installer /dev/tty handoff.
• Root cause: the hidden prompt rejected its promise and re-raised SIGINT, but the command boundary rethrew the rejection before the signal handler completed.
• Detection gap: prompt tests covered signal delivery, and the package contract covered prompt EOF, but no compiled test exercised hidden-prompt SIGINT through the onboarding exit handler or installer TTY handoff.

Type of Change

• Code change (feature, bug fix, or refactor)
• Code change with doc updates
• Doc only (prose changes, no code sample modifications)
• Doc only (includes code sample changes)

Quality Gates

• Tests added or updated for changed behavior
• Existing tests cover changed behavior — justification:
• Tests not applicable — justification:
• Docs updated for user-facing behavior changes
• Docs not applicable — justification: The fix restores the documented resumable-interruption behavior; command reference, quickstart, headless recovery, and credential-storage guidance remain accurate.
• Sensitive paths changed (security, policy, credentials, preflight, onboarding, inference, runner, sandbox, or messaging)
• Sensitive-path review completed or maintainer-approved waiver recorded — reviewer/approval link/justification: Accepted issue [Interactive Onboard] Ctrl+C at NVIDIA API-key prompt prints raw Node stack trace #7439 defines the secret-input constraints. The prompt cleanup and credential handling are unchanged; compiled regressions verify status 130, resume guidance, installer TTY handling, and no stack or credential output.
• Non-success, skipped, or missing CI check accepted by maintainer — check name, approval link, and follow-up issue:

Documentation Writer Review

• Documentation writer subagent reviewed the completed changes
• Result: no-docs-needed
• Evidence: PASS. The fix removes an unintended stack trace after SIGINT and preserves the documented onboard --resume recovery flow. It does not change commands, flags, configuration, schemas, or supported behavior. No docs/ or fern/ files changed. Changed comments and test titles follow WRITING.md. Focused validation passed 2 files and 22 tests.
• Agent: Codex Desktop
• PR: fix(onboarding): suppress credential prompt interrupt stack #7442

DGX Station Hardware Evidence

• Tested on DGX Station
• Tested commit:
• Station profile/scenario:
• Result:
• Supporting evidence:

Verification

• PR description includes a Signed-off-by: line and every commit appears as Verified in GitHub
• Normal pre-commit, commit-msg, and pre-push hooks passed, or npm run check:diff passed when hooks were skipped or unavailable — npm run check:diff passed on e533ac6f6 against canonical main at d42f73609.
• Targeted behavior tests pass for the current change set, or tests are marked not applicable above — command/result or justification: npx vitest run --project cli --project package-contract src/lib/onboard/command.test.ts test/package-contract/onboard/onboard-stdin-eof.test.ts passed 2 files and 22 tests on e533ac6f6.
• Applicable broad gate passed — npm test for broad runtime/test-harness changes; npm run check for repo-wide validation/coverage changes — command/result:
• Quality Gates section completed with required justifications or waivers
• No secrets, API keys, or credentials committed
• npm run docs builds without warnings (doc changes only)
• Doc pages follow the style guide (doc changes only)
• New doc pages include SPDX header and frontmatter (new pages only)

---

Signed-off-by: Senthil Ravichandran senthilr@nvidia.com

[coderabbitai]

📝 Walkthrough

Walkthrough

Onboarding now distinguishes EOF from SIGINT prompt cancellation, suppresses rejected prompt errors for Ctrl+C, and adds direct CLI and installer-handoff regression tests for exit status, resume guidance, and stack-trace suppression.

Changes

Prompt cancellation

Layer / File(s)	Summary
SIGINT cancellation handling src/lib/onboard/command.ts, src/lib/onboard/command.test.ts	Prompt cancellation is classified as EOF, SIGINT, or another error; SIGINT returns successfully without invoking exit, while EOF remains non-failing.
CLI interruption regression coverage test/package-contract/onboard/onboard-stdin-eof.test.ts	Direct and /dev/tty installer-style interruptions verify status 130, resume guidance, and the absence of prompt errors or internal stack traces.

Estimated code review effort: 3 (Moderate) | ~25 minutes

Suggested reviewers: apurvvkumaria

Sequence Diagram(s)

sequenceDiagram
  participant User
  participant Prompt
  participant OnboardCommand
  participant CLI
  User->>Prompt: Send Ctrl+C
  Prompt-->>OnboardCommand: Reject with SIGINT
  OnboardCommand-->>CLI: Suppress prompt error
  CLI-->>User: Show resume guidance and exit 130

Loading

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Linked Issues check	✅ Passed	The changes address SIGINT handling at the onboarding prompt and add coverage for direct and installer /dev/tty flows.
Out of Scope Changes check	✅ Passed	The added test and helper changes support the onboarding interrupt fix and do not appear unrelated.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly matches the main change: handling onboarding prompt interruptions and suppressing interrupt stack traces.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands.}

[github-actions]

PR Review Advisor — Informational

Advisor assessment: Informational / high confidence
Next action: No advisor follow-up needed.
Findings: 0 blockers · 0 warnings · 0 suggestions
Status: No actionable findings remain in the canonical review ledger.

Model lanes

• GPT-5.6 Terra (primary): Completed · high confidence · 0 blockers · 0 warnings · 0 suggestions
• Nemotron 3 Ultra (second opinion): Completed · high confidence · 0 blockers · 2 warnings · 0 suggestions
• Model comparison: normalized findings differ; normalized E2E selections differ; Nemotron reported the same number of blockers, 2 more warnings, the same number of suggestions.

Nemotron output stays in workflow artifacts and does not change the assessment above.

E2E guidance

Advisory only. E2E / PR Gate selects and runs jobs independently.

Recommended E2E: onboard-repair, onboard-resume, cloud-onboard

Workflow run details

This automated review informs maintainers. Warnings and suggestions do not require a response. A maintainer decides whether to merge.