Repository navigation
Conversation
…VIDIA#5619) Add a skip-aware live check (07-deepagents-code-headless-inference.sh) that runs `dcode -n` inside a built Deep Agents Code sandbox and asserts: - config.toml routes through the managed https://inference.local endpoint - headless `dcode -n` returns a deterministic response or actionable provider/model error within a timeout (no hang/ambiguous failure) - no real provider/proxy credentials (nvapi-/sk-/xox.-/AKIA shapes) appear in config.toml, .env, .mcp.json, /tmp/nemoclaw-proxy-env.sh, or the captured output The script self-skips when the sandbox is not a Deep Agents Code sandbox, mirroring the existing 05/06 checks. A unit assertion in the image test registers the check and verifies its skip guard, prompt, inference route, and secret-scan content. The live green run requires a built sandbox plus the managed inference endpoint and is gated to the live e2e environment. Signed-off-by: Abhimanyu Kumar <abhimanyukumar7290@gmail.com>
|
This repository limits contributors to 10 open pull requests. Please close or merge existing PRs before opening new ones. |
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughAdds a new Bash e2e check script ( ChangesDeep Agents Code headless inference e2e check
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related issues
Poem
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
…5619) (#5789) Closes #5619 Supersedes #5652 Adds `test/e2e/e2e-cloud-experimental/checks/07-deepagents-code-headless-inference.sh`, a skip-aware live check (mirroring the existing `05`/`06` Deep Agents Code checks) for headless `dcode -n`: - `config.toml` routes through the managed `https://inference.local` endpoint. - Headless `dcode -n "<deterministic prompt>"` returns a response or a deterministic, actionable provider/model error within a timeout — never a hang. - No provider or proxy credentials appear in `config.toml`, `.env`, `.mcp.json`, `/tmp/nemoclaw-proxy-env.sh`, or the captured output. The check self-skips when the sandbox is not a Deep Agents Code sandbox. A unit assertion in `langchain-deepagents-code-image.test.ts` registers the check and verifies its skip guard, prompt, inference route, and secret scan. Signed-off-by: Abhimanyu Kumar <abhimanyukumar7290@gmail.com> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Tests** * Added an end-to-end Bash check for “Deep Agents Code” headless inference in a managed sandbox. * Validates routing to the expected local inference endpoint and use of managed placeholder API key references. * Improves headless execution verification with explicit timeout handling and deterministic success response checks. * Rejects ambiguous output and local-failure style outcomes; adds classification coverage for pass/actionable errors/timeouts. * Adds secret-like value scanning across sandbox config and captured runtime/proxy artifacts. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Signed-off-by: Abhimanyu Kumar <abhimanyukumar7290@gmail.com> Signed-off-by: Carlos Villela <cvillela@nvidia.com> Co-authored-by: Carlos Villela <cvillela@nvidia.com>
…VIDIA#5619) (NVIDIA#5789) Closes NVIDIA#5619 Supersedes NVIDIA#5652 Adds `test/e2e/e2e-cloud-experimental/checks/07-deepagents-code-headless-inference.sh`, a skip-aware live check (mirroring the existing `05`/`06` Deep Agents Code checks) for headless `dcode -n`: - `config.toml` routes through the managed `https://inference.local` endpoint. - Headless `dcode -n "<deterministic prompt>"` returns a response or a deterministic, actionable provider/model error within a timeout — never a hang. - No provider or proxy credentials appear in `config.toml`, `.env`, `.mcp.json`, `/tmp/nemoclaw-proxy-env.sh`, or the captured output. The check self-skips when the sandbox is not a Deep Agents Code sandbox. A unit assertion in `langchain-deepagents-code-image.test.ts` registers the check and verifies its skip guard, prompt, inference route, and secret scan. Signed-off-by: Abhimanyu Kumar <abhimanyukumar7290@gmail.com> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Tests** * Added an end-to-end Bash check for “Deep Agents Code” headless inference in a managed sandbox. * Validates routing to the expected local inference endpoint and use of managed placeholder API key references. * Improves headless execution verification with explicit timeout handling and deterministic success response checks. * Rejects ambiguous output and local-failure style outcomes; adds classification coverage for pass/actionable errors/timeouts. * Adds secret-like value scanning across sandbox config and captured runtime/proxy artifacts. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Signed-off-by: Abhimanyu Kumar <abhimanyukumar7290@gmail.com> Signed-off-by: Carlos Villela <cvillela@nvidia.com> Co-authored-by: Carlos Villela <cvillela@nvidia.com>
Closes #5619
Adds
test/e2e/e2e-cloud-experimental/checks/07-deepagents-code-headless-inference.sh, a skip-aware live check (mirroring the existing05/06Deep Agents Code checks) for headlessdcode -n:config.tomlroutes through the managedhttps://inference.localendpoint.dcode -n "<deterministic prompt>"returns a response or a deterministic, actionable provider/model error within a timeout — never a hang.config.toml,.env,.mcp.json,/tmp/nemoclaw-proxy-env.sh, or the captured output.The check self-skips when the sandbox is not a Deep Agents Code sandbox. A unit assertion in
langchain-deepagents-code-image.test.tsregisters the check and verifies its skip guard, prompt, inference route, and secret scan.Signed-off-by: Abhimanyu Kumar abhimanyukumar7290@gmail.com