Repository navigation
test(cli): narrow sandbox logs coverage ignores - #2940
Merged
Merged
Conversation
This reverts commit 4ebeae4.
wscurran
added
CI/CD
refactor
This was referenced May 4, 2026
Signed-off-by: Carlos Villela <cvillela@nvidia.com>
cv
added a commit
that referenced
this pull request
May 5, 2026
## Summary Split share oclif command classes out of the SSHFS action/helper module so parser adapters and action logic are independently testable. ## Stack Navigation - Position: 41 of 60 - Previous PR: [#2938 — test(cli): cover sandbox oclif command adapters](#2938) - Next PR: [#2940 — test(cli): narrow sandbox logs coverage ignores](#2940) ## Changes - Added `share-cli-commands.ts` for the share parent and mount/unmount/status oclif adapters. - Left SSHFS action helpers in `share-command.ts`. - Updated the oclif command registry to import share command classes from the new adapter module. - Added direct share adapter tests with mocked share actions. ## Type of Change - [x] Code change (feature, bug fix, or refactor) - [ ] Code change with doc updates - [ ] Doc only (prose changes, no code sample modifications) - [ ] Doc only (includes code sample changes) ## Verification - [x] `npx prek run --all-files` passes - [x] `npm test` passes - [x] Tests added or updated for new or changed behavior - [x] No secrets, API keys, or credentials committed - [ ] Docs updated for user-facing behavior changes - [ ] `make docs` builds without warnings (doc changes only) - [ ] Doc pages follow the [style guide](https://github.com/NVIDIA/NemoClaw/blob/main/docs/CONTRIBUTING.md) (doc changes only) - [ ] New doc pages include SPDX header and frontmatter (new pages only) --- Signed-off-by: Carlos Villela <cvillela@nvidia.com> --------- Signed-off-by: Carlos Villela <cvillela@nvidia.com>
…-sandbox-logs-coverage-ignore
cv
marked this pull request as ready for review
May 5, 2026 22:03
cv
enabled auto-merge (squash)
May 5, 2026 22:03
cv
added a commit
that referenced
this pull request
May 5, 2026
## Summary Remove broad coverage ignores from the remaining simple global oclif adapters and the credentials adapter, then cover their parser-to-action mappings directly. ## Stack Navigation - Position: 43 of 60 - Previous PR: [#2940 — test(cli): narrow sandbox logs coverage ignores](#2940) - Next PR: [#2943 — test(cli): cover global action facade](#2943) ## Changes - Removed file-level V8 ignores from debug, deploy, gateway-token, root help/version, tunnel, uninstall, and credentials adapters. - Added direct source-level adapter tests with mocked action/runtime dependencies. - Added source-level credentials tests for top-level usage, provider listing, and `credentials reset --yes`. - Added a test hook for the gateway-token adapter so source tests avoid loading the heavy onboard module. ## Type of Change - [x] Code change (feature, bug fix, or refactor) - [ ] Code change with doc updates - [ ] Doc only (prose changes, no code sample modifications) - [ ] Doc only (includes code sample changes) ## Verification - [x] `npx prek run --all-files` passes - [x] `npm test` passes - [x] Tests added or updated for new or changed behavior - [x] No secrets, API keys, or credentials committed - [ ] Docs updated for user-facing behavior changes - [ ] `make docs` builds without warnings (doc changes only) - [ ] Doc pages follow the [style guide](https://github.com/NVIDIA/NemoClaw/blob/main/docs/CONTRIBUTING.md) (doc changes only) - [ ] New doc pages include SPDX header and frontmatter (new pages only) --- Signed-off-by: Carlos Villela <cvillela@nvidia.com> --------- Signed-off-by: Carlos Villela <cvillela@nvidia.com>
wscurran
added
area: ci
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace the file-level coverage ignore on sandbox log actions with tested pure helpers and narrow ignores around subprocess-only paths.
Stack Navigation
Changes
sandbox-logs-action.ts.Type of Change
Verification
npx prek run --all-filespassesnpm testpassesmake docsbuilds without warnings (doc changes only)Signed-off-by: Carlos Villela cvillela@nvidia.com
Summary by CodeRabbit
New Features
Tests
Refactor