[cv]

Summary

Hardens the oclif bridge introduced for nemoclaw list so command help uses the active launcher branding, including the nemohermes alias. It also centralizes legacy dispatch through a runOclif() helper and relaxes uninstall helper test timeouts that were flaky under full-suite load.

Changes

• Set the oclif config bin to the active CLI_NAME and invoke command classes with that config so alias help renders correctly.
• Add a shared runOclif() delegation helper in src/nemoclaw.ts and route list through it.
• Add CLI coverage for nemohermes list --help branding.
• Increase timeouts for uninstall helper tests that can exceed Vitest's default when the full CLI suite runs concurrently.

Type of Change

• Code change (feature, bug fix, or refactor)
• Code change with doc updates
• Doc only (prose changes, no code sample modifications)
• Doc only (includes code sample changes)

Verification

• npx prek run --all-files passes
• npm test passes
• Tests added or updated for new or changed behavior
• No secrets, API keys, or credentials committed
• Docs updated for user-facing behavior changes
• make docs builds without warnings (doc changes only)
• Doc pages follow the style guide (doc changes only)
• New doc pages include SPDX header and frontmatter (new pages only)

AI Disclosure

• AI-assisted — tool: OpenAI Codex

---

Signed-off-by: Carlos Villela cvillela@nvidia.com

Summary by CodeRabbit

• Tests

  • Added validation for the nemohermes command alias to ensure correct branding in CLI output.
  • Adjusted execution timeouts for uninstall operation tests.

• Refactor

  • Optimized command execution flow for improved reliability.
  • Improved sandbox listing implementation through centralized configuration.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: f91f286e-ab09-4f2a-b393-a0a157279969

📥 Commits

Reviewing files that changed from the base of the PR and between cad2e10 and 5e997cb.

📒 Files selected for processing (4)

• src/lib/oclif-runner.ts
• src/nemoclaw.ts
• test/cli.test.ts
• test/uninstall.test.ts

---

📝 Walkthrough

Walkthrough

The oclif command runner is refactored to explicitly manage command execution by setting the bin value from CLI_NAME, finding and loading commands manually, and executing prerun and postrun hooks around command instances. A new test validates the nemohermes command alias works correctly. Test timeouts are standardized to 60 seconds.

Changes

Cohort / File(s)	Summary
Command Runner Refactoring src/lib/oclif-runner.ts, src/nemoclaw.ts	Core runner logic now sets bin from CLI_NAME and explicitly handles oclif prerun/postrun hooks. A new runOclif helper centralizes shared configuration in nemoclaw.ts.
Test Coverage Expansion test/cli.test.ts	New test validates that the nemohermes command alias displays correct branding in CLI output and does not show nemoclaw branding.
Test Configuration test/uninstall.test.ts	Uninstall helper tests updated with explicit 60-second timeouts to address performance variability.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Poem

🐰 Command hooks dance in sequence true,
Pre and post, the runner's new view,
Nemohermes alias finds its place,
Tests keep pace with proper grace!

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 20.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'refactor(cli): harden oclif bridge' directly matches the main objective of hardening the oclif bridge to ensure command help uses active launcher branding.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch refactor/oclif-bridge-cleanup

---

_{Review rate limit: 9/10 reviews remaining, refill in 6 minutes.}

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[ericksoa]

Reviewed locally at 5e997cb. Focused validation passed: npm run build:cli; npx vitest run test/cli.test.ts test/nemohermes-alias.test.ts test/uninstall.test.ts.