Repository navigation
refactor(cli): remove TS dependency on onboard-session shim - #1543
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughA module import migration in Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
) ## Summary Remove the `src/lib/runtime-recovery.ts` dependency on the legacy `bin/lib/onboard-session` shim and import the TypeScript module directly. ## Why This is the first small cleanup PR in the NVIDIA#924 follow-through: reduce TS -> legacy JS backedges so the CLI TS modules form cleaner islands. ## Changes - replace `require("../../bin/lib/onboard-session")` with a local TS import - keep runtime behavior unchanged ## Testing - `npm run build:cli` - `npx vitest run src/lib/runtime-recovery.test.ts` Relates to NVIDIA#924. <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Refactor** * Updated internal module loading system to improve code maintainability and consistency. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
Summary
Remove the
src/lib/runtime-recovery.tsdependency on the legacybin/lib/onboard-sessionshim and import the TypeScript module directly.Why
This is the first small cleanup PR in the #924 follow-through: reduce TS -> legacy JS backedges so the CLI TS modules form cleaner islands.
Changes
require("../../bin/lib/onboard-session")with a local TS importTesting
npm run build:clinpx vitest run src/lib/runtime-recovery.test.tsRelates to #924.
Summary by CodeRabbit