Skip to content

ci(e2e): install native Podman prerequisites for two targets - #12353

Merged
ericksoa merged 4 commits into
mainfrom
codex/fix-scoped-podman-e2e-prereqs
Sep 28, 2026
Merged

ericksoa merged 4 commits into
mainfrom
codex/fix-scoped-podman-e2e-prereqs

Conversation

@ericksoa

@ericksoa ericksoa commented Sep 27, 2026 •

Copy link
Copy Markdown
Member

Outcome

The native Podman GPU re-onboarding and Hermes Slack jobs receive their required host packages before workspace preparation. Both currently fail the missing conmon prerequisite before exercising their product behavior.

Reason

The final full run for #12354 still reproduced this shared setup failure in GPU re-onboarding and Hermes Slack.

Changes

  • Declare the seven native Podman prerequisite packages in the owning target catalogue for these two targets. Generate them through the existing host_packages input only for their Podman rows.
  • Use the shared profile's existing pinned host-dependency action, with package selection owned by the target catalogue.
  • Validate package selections against the exact target/runtime plan. Focused tests reject delivery to Docker or unrelated targets, missing packages, and standalone runc.
  • Include merged fix(openclaw): repair agent scope and inference restart handoff #12354 through a normal merge commit so qualification includes the scope-handoff repair. Relative to current main, this PR changes only five workflow/planner/support-guidance files.

Application code, live assertions, timeouts, cleanup, and versions are unchanged by this PR. The existing host helper retains apt-get --no-remove, its reviewed package allowlist, and the runner's container-runtime packages.

Verification

  • Current head: 41fb586437713d0445dbaa8ebe9d6164ba60f370.
  • Focused local tests after the dependency merge: 159 passed across workflow planning, standard-profile boundary, and host-dependency boundary suites. No local live E2E.
  • Full-plan comparison before the dependency merge: exactly two package bindings changed; every other planner field was identical.
  • Normal commit hooks passed, including growth, source-shape budget, semantic phase checks, formatting, and secret scanning.
  • Four-case qualification passed GPU re-onboarding and Hermes Slack on both Docker and Podman at a44e862dc44b3248899010a20041f6feefc5116d. Verified artifacts show zero cleanup failures, the exact seven packages installed on Podman, and the package step skipped on Docker.
  • The final commit changes only the owning README to resolve the documentation review finding. Executable code and the complete Docker/Podman plan are identical to the four-case qualified revision.
  • Full unfiltered Docker/Podman qualification and refreshed CI/automated review are pending on the final head. No current-head full-suite pass is claimed.

Review notes

The original architecture finding F-architecture-standard-work-bdec99c28a2f8eb3281b is resolved: package selection belongs to the target catalogue and reaches the shared installer through its existing input. On a44e862, eight Advisor specialists reported no findings, including architecture and security. The documentation specialist found an outdated package-limit sentence; the final README-only commit updates that authoritative contract and removes duplicated prose. Final-head evaluation remains required. The diff contains no secrets, API keys, or credentials.


Signed-off-by: Aaron Erickson aerickson@nvidia.com

Signed-off-by: Aaron Erickson <aerickson@nvidia.com>
@ericksoa ericksoa self-assigned this Sep 27, 2026
@copy-pr-bot

copy-pr-bot Bot commented Sep 27, 2026

Copy link
Copy Markdown

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@coderabbitai

coderabbitai Bot commented Sep 27, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration

Configuration used: Repository: NVIDIA/NemoClaw/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 325507ba-752b-4d82-b999-68b949bc1305

📥 Commits

Reviewing files that changed from the base of the PR and between 2e8a2bc and 41fb586.

📒 Files selected for processing (5)
  • .github/workflows/e2e-standard-profile.yaml
  • test/e2e/README.md
  • test/e2e/support/workflow-plan.test.ts
  • tools/e2e/target-catalogue.mts
  • tools/e2e/workflow-plan.mts
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Comment @coderabbitai help to get the list of available commands.

@github-code-quality

github-code-quality Bot commented Sep 27, 2026 •

Copy link
Copy Markdown
Contributor

Code Coverage Overview

Languages: TypeScript

TypeScript / code-coverage/plugin

The overall line coverage in commit 41fb586 in the codex/fix-scoped-pod... branch remains at 96%, unchanged from commit 63002cd in the main branch.

TypeScript / code-coverage/cli

The overall line coverage in commit 41fb586 in the codex/fix-scoped-pod... branch remains at 84%, unchanged from commit 63002cd in the main branch.

Show a line coverage summary of the most impacted files.
File main 63002cd codex/fix-scoped-pod... 41fb586 +/-
src/lib/onboard...or-reporting.ts 95% 90% -5%
src/lib/onboard...eway-service.ts 85% 85% 0%
src/lib/domain/...ort-document.ts 97% 97% 0%
src/lib/onboard...uild-context.ts 87% 87% 0%
src/lib/sandbox...rce-identity.ts 84% 84% 0%
src/lib/state/m...-acquisition.ts 80% 80% 0%

Updated September 28, 2026 00:14 UTC

@github-actions

Copy link
Copy Markdown
Contributor

PR Review Advisor finished for commit 41fb586. Include the Advisor findings in the complete PR feedback collection. Verify and group valid findings before repair.

Request review only when Require no Advisor blockers is green.

All previous runs

@ericksoa
ericksoa marked this pull request as ready for review September 28, 2026 01:05
@ericksoa
ericksoa merged commit efd7bd1 into main Sep 28, 2026
465 of 514 checks passed
@ericksoa
ericksoa deleted the codex/fix-scoped-podman-e2e-prereqs branch September 28, 2026 01:05
@wscurran wscurran added area: ci CI workflows, checks, release automation, or GitHub Actions area: e2e End-to-end tests, nightly failures, or validation infrastructure chore Build, CI, dependency, or tooling maintenance platform: container Affects Docker, containerd, Podman, or images labels Oct 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: ci CI workflows, checks, release automation, or GitHub Actions area: e2e End-to-end tests, nightly failures, or validation infrastructure chore Build, CI, dependency, or tooling maintenance platform: container Affects Docker, containerd, Podman, or images

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants