Repository navigation
ci(e2e): install native Podman prerequisites for two targets - #12353
Conversation
Signed-off-by: Aaron Erickson <aerickson@nvidia.com>
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configurationConfiguration used: Repository: NVIDIA/NemoClaw/.coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (5)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Code Coverage OverviewLanguages: TypeScript TypeScript / code-coverage/pluginThe overall line coverage in commit 41fb586 in the TypeScript / code-coverage/cliThe overall line coverage in commit 41fb586 in the Show a line coverage summary of the most impacted files.
Updated |
|
PR Review Advisor finished for commit Request review only when Require no Advisor blockers is green. |
Outcome
The native Podman GPU re-onboarding and Hermes Slack jobs receive their required host packages before workspace preparation. Both currently fail the missing
conmonprerequisite before exercising their product behavior.Reason
The final full run for #12354 still reproduced this shared setup failure in GPU re-onboarding and Hermes Slack.
Changes
host_packagesinput only for their Podman rows.runc.Application code, live assertions, timeouts, cleanup, and versions are unchanged by this PR. The existing host helper retains
apt-get --no-remove, its reviewed package allowlist, and the runner's container-runtime packages.Verification
41fb586437713d0445dbaa8ebe9d6164ba60f370.a44e862dc44b3248899010a20041f6feefc5116d. Verified artifacts show zero cleanup failures, the exact seven packages installed on Podman, and the package step skipped on Docker.Review notes
The original architecture finding
F-architecture-standard-work-bdec99c28a2f8eb3281bis resolved: package selection belongs to the target catalogue and reaches the shared installer through its existing input. Ona44e862, eight Advisor specialists reported no findings, including architecture and security. The documentation specialist found an outdated package-limit sentence; the final README-only commit updates that authoritative contract and removes duplicated prose. Final-head evaluation remains required. The diff contains no secrets, API keys, or credentials.Signed-off-by: Aaron Erickson aerickson@nvidia.com