Repository navigation
ci: correct bootstrap diagnostics trust hash - #12306
Conversation
Signed-off-by: Rebecca Sliter <571084+rsliter@users.noreply.github.com>
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: NVIDIA/NemoClaw/.coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 10 remain after this review. 📝 WalkthroughWalkthroughThe v0.0.116 trusted Brev template hash allowlist now uses the digest for the self-contained ChangesBrev template pin
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~2 minutes Change: Bug fix Suggested reviewers: Merge Risk: ⚪ Minimal · up to No actionable trust-record defect is established. The separate 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Code Coverage OverviewLanguages: TypeScript TypeScript / code-coverage/pluginThe overall line coverage in commit 683edb2 in the TypeScript / code-coverage/cliThe overall line coverage in commit 683edb2 in the Show a line coverage summary of the most impacted files.
Updated |
Signed-off-by: Aaron Erickson <aerickson@nvidia.com>
|
PR Review Advisor finished for commit Request review only when Require no Advisor blockers is green. |
ericksoa
left a comment
There was a problem hiding this comment.
Reviewed exact head 683edb2. The two-line independent trust update authorizes the diagnostic template in #12239 without changing the shipped bootstrap or release pins. CI, growth, installer hashes, and runtime qualification passed; 81 focused installer tests passed. The duplicated Advisor finding conflates the unchanged 98c46c template with the downstream 60aa3d template; the parser comparisons and disposition are recorded in this PR.
Outcome
Authorize the exact self-contained bootstrap diagnostic template prepared in #12239 through the independent base-trusted allowlist. This PR changes only one digest and its comment; the shipped bootstrap and release pins are unchanged.
Reason
The prior prerequisite recorded an inert raw script digest. The protected parser compares a normalized operational-template digest. The candidate now keeps diagnostics with the executing bootstrap and covers reviewed-npm setup as well as root/plugin dependencies, so its exact normalized digest is
60aa3d473597638b50bc9ba637a86dee08aed5727c1d0297f72476c0c6690f2f.Related issues
Refs #12192. Independent prerequisite for #12239 at
64b282d1b2e7f44563d10c86ed31e470e0c418d3.Changes
Verification
Prerequisite:
683edb278ec65581caeb2a610544599d6b0b4032. Candidate data:64b282d1b2e7f44563d10c86ed31e470e0c418d3.vitest run --project integration test/install/installer-hash-check.test.ts: 81 passed.Review notes
Continues Rebecca Sliter's existing prerequisite without rewriting its history. Sensitive path:
scripts/checks/extract-installer-pins.mts. Self-review confirmed the exact candidate preimage, normalized digest, unchanged shipped bootstrap, and independent trust boundary. The current-head Advisor completed all nine specialists. Eight were clear; Operability reported one duplicated P1. Its claim that the new digest authorizes the unchangedtail -3script is a false positive, with this concrete disposition:683edb278ec65581caeb2a610544599d6b0b4032normalizes to98c46cfee5bc38cd378a991a7c60573836a6c774008caf5c5dd7bc6a1910e1ce. Both the existing main parser and this prerequisite parser already accept it.60aa3d473597638b50bc9ba637a86dee08aed5727c1d0297f72476c0c6690f2fdigest belongs to the revised candidate bootstrap, whose inline diagnostic wrapper covers reviewed-npm, root, and plugin stages. Its 19 passing tests include early causal output, exact failure statuses, missing output, redaction, and cleanup.The finding conflates the unchanged prerequisite checkout with the downstream candidate. The code remains separated to preserve independent authorization. The Advisor aggregate remains red; this records the evidence-based disposition and does not claim a green Advisor result.
Merge requires explicit maintainer authorization. This PR enables diagnostic qualification; it does not repair or classify the underlying npm failure.
Signed-off-by: Aaron Erickson aerickson@nvidia.com