Skip to content

test(e2e): retire redundant live targets - #11960

Closed
rsliter wants to merge 1 commit into
mainfrom
codex/11946-retire-independent-e2e
Closed

rsliter wants to merge 1 commit into
mainfrom
codex/11946-retire-independent-e2e

Conversation

@rsliter

@rsliter rsliter commented Sep 17, 2026

Copy link
Copy Markdown
Collaborator

Outcome

NemoClaw no longer schedules three redundant E2E executions: the buildless managed-image integration test in Shared E2E, the standalone device-auth-health target, and the standalone cloud-inference target. Their useful coverage remains in ordinary integration tests, deterministic gateway-readiness tests, dashboard-remote-bind, and full-e2e.

Reason

These jobs repeated behavior already exercised at a cheaper or more representative boundary. Retiring them reduces the default E2E plan by three coverage rows and removes two standalone live test files without dropping the cloud credential-boundary check.

Related issues

Part of #11946

Changes

  • Remove the buildless onboarding test from credential-free Shared E2E discovery while retaining it in the integration project.
  • Replace the live 401 health target with a deterministic isGatewayHttpReady HTTP 401 contract test; retain dashboard-remote-bind for the real remote-exposure journey.
  • Move the sandbox credential scan into full-e2e, retire the standalone cloud inference target and its incidental skill-layout checks, and route security/control-plane risk plans to full-e2e.
  • Reject all three retired selectors and update the workflow plan, runtime matrix, advisor fixtures, mock-parity ownership, and assertion budget.

Verification

  • Focused Vitest coverage for gateway readiness, credential scanning, workflow planning, runtime matrices, E2E invocation, and advisor mappings — passed.
  • npm run checks:repository — 19 selected repository checks passed.
  • npm --prefix nemoclaw run typecheck — passed.
  • Repository pre-commit and commit-message hooks — passed, including formatting, lint, secret scanning, semantic E2E phases, source-shape budget, and growth guardrails.
  • Aggregate changed-test runs — all relevant tests passed; unrelated workflow-boundary tests intermittently exceeded their shared 5-second timeout under parallel local load and passed immediately when rerun by file.
  • Diff review — no secrets, API keys, or credentials added.

Review notes

The EXDEV case from closed #11547 is intentionally excluded from this PR.


Signed-off-by: Rebecca Sliter 571084+rsliter@users.noreply.github.com

@copy-pr-bot

copy-pr-bot Bot commented Sep 17, 2026

Copy link
Copy Markdown

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@coderabbitai

coderabbitai Bot commented Sep 17, 2026

Copy link
Copy Markdown
Contributor

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

Comment @coderabbitai help to get the list of available commands.

@github-code-quality

Copy link
Copy Markdown
Contributor

Code Coverage Overview

Languages: TypeScript

TypeScript / code-coverage/plugin

The overall line coverage in commit 52bd619 in the codex/11946-retire-i... branch remains at 96%, unchanged from commit 52d8b81 in the main branch.

@rsliter

rsliter commented Sep 17, 2026

Copy link
Copy Markdown
Collaborator Author

Closing as superseded. PR #11969 merged the cloud-inference and device-auth retirement, PR #11909 owns the remaining buildless test removal, and PR #11906 removed the EXDEV path. The obsolete exact-head E2E run for this branch was canceled after the overlapping changes landed.

@rsliter rsliter closed this Sep 17, 2026
@wscurran wscurran added area: e2e End-to-end tests, nightly failures, or validation infrastructure area: security Security controls, permissions, secrets, or hardening labels Oct 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: e2e End-to-end tests, nightly failures, or validation infrastructure area: security Security controls, permissions, secrets, or hardening

Projects

None yet

Development

Successfully merging this pull request may close these issues.

test(e2e): keep OpenClaw plugin EXDEV coverage at live boundaries

2 participants