fix(build): sync plugin cache seed lock digest by ericksoa · Pull Request #11315 · NVIDIA/NemoClaw

ericksoa · 2026-09-09T17:26:53Z

Outcome

The locked plugin cache-seed manifest matches nemoclaw/package-lock.json again. The OpenClaw integrity-pin contract and CLI shard 6 no longer reject current main.

Reason

PR #10518 changed the plugin lockfile while leaving the generated cache-seed digest at the previous value. Current main CI therefore fails before unrelated PRs can reach a green gate.

Related issues

Refs #10518.

Blocks exact qualification of #11310.

Changes

Update the existing cache-seed manifest digest to the SHA-256 of the current plugin lockfile.
Keep the archive inventory and every other cache-seed field unchanged because the production archive set did not change.

Verification

shasum -a 256 nemoclaw/package-lock.json — produced 55a512d782f8a4ad0eac39078b0e652400bf8580767b3a9ac5282a05bae47042.
npx vitest run test/agents/openclaw/openclaw-integrity-pin-contract.test.ts test/install/materialize-locked-npm-cache-seed.test.ts — 16 tests passed.
NODE_OPTIONS=--max-old-space-size=8192 npm run validate:pr — passed after building the current-main CLI and plugin artifacts required by a fresh checkout.
Diff inspection confirmed that no secrets, API keys, or credentials are present.

Signed-off-by: Aaron Erickson aerickson@nvidia.com

Summary by CodeRabbit

Chores
- Updated the npm cache seed manifest checksum.

Signed-off-by: Aaron Erickson <aerickson@nvidia.com>

copy-pr-bot · 2026-09-09T17:26:56Z

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

coderabbitai · 2026-09-09T17:27:03Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 9f2efc2f-89de-4534-bf3c-d8e445ca8724

📥 Commits

Reviewing files that changed from the base of the PR and between 7e4bdf2 and fbeef73.

📒 Files selected for processing (1)

tools/mcp-tool-discovery-runtime/npm-cache-seed/manifest.json

Included review availability: Your plan provides up to 12 included reviews per hour; 9 remain after this review.

📝 Walkthrough

Walkthrough

The npm cache seed manifest now contains a new lockSha256 digest.

Changes

NPM cache seed

Layer / File(s)	Summary
Update lockfile digest `tools/mcp-tool-discovery-runtime/npm-cache-seed/manifest.json`	The manifest replaces the existing `lockSha256` value with a new SHA-256 digest.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to fbeef

The cache-seed manifest digest is updated to align with the current plugin lockfile, restoring integrity validation without changing archive inventory or runtime behavior. No current merge-blocking risk remains.

Suggested reviewers: senthilr-nv, cv

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and concisely describes the manifest digest update that synchronizes the plugin cache seed with the current lockfile.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch fix/main-plugin-cache-seed-lock

_{Comment @coderabbitai help to get the list of available commands.}

github-code-quality · 2026-09-09T17:28:02Z

Code Coverage Overview

Languages: TypeScript

TypeScript / code-coverage/plugin

The overall line coverage in commit fbeef73 in the fix/main-plugin-cach... branch remains at 96%, unchanged from commit 7e4bdf2 in the main branch.

TypeScript / code-coverage/cli

The overall line coverage in commit fbeef73 in the fix/main-plugin-cach... branch remains at 83%, unchanged from commit 632986d in the main branch.

Show a line coverage summary of the most impacted files.

File	`main` 632986d	`fix/main-plugin-cach...` fbeef73	+/-
`src/lib/actions...ard-recovery.ts`	91%	84%	-7%
`src/lib/onboard...able-receipt.ts`	71%	83%	+12%
`src/lib/adapter...penshell/sdk.ts`	0%	75%	+75%
`src/lib/domain/...xport-source.ts`	0%	90%	+90%
`src/lib/cli/con...-diagnostics.ts`	0%	90%	+90%
`src/lib/adapter...xport-source.ts`	0%	93%	+93%
`src/lib/adapter...-export-file.ts`	0%	94%	+94%
`src/lib/actions...xport-source.ts`	0%	94%	+94%
`src/lib/adapter...ell/sdk-read.ts`	0%	100%	+100%
`src/lib/actions...onfig/export.ts`	0%	100%	+100%

_{Updated September 09, 2026 18:27 UTC}

github-actions · 2026-09-09T18:32:21Z

PR Review Advisor finished for commit fbeef73. Include the Advisor findings in the complete PR feedback collection. Verify and group valid findings before repair.

All previous runs

cjagwani · 2026-09-09T18:37:29Z

Confirmed this current-main regression also blocks PR #11316 and unrelated PR #11319. On both, CLI shard 6 reaches the tests and fails the same integrity-pin assertion: manifest lockSha256 66bef669196bb1c61385871e369542d3c321c277adb0f0e2e9f0ad972106b163 versus current nemoclaw/package-lock.json SHA-256 55a512d782f8a4ad0eac39078b0e652400bf8580767b3a9ac5282a05bae47042. The focused one-line change here is the canonical fix.

ericksoa · 2026-09-09T18:37:49Z

Maintainer CI classification for commit fbeef73e3c4dda0c32519132ddf6e5e53360df57: the trusted checker sees the later edited-event changes job as skipped. The actual gating changes job on run 34382965584 succeeded, followed by 12/12 successful CLI shards, successful merged coverage, and a successful aggregate checks job. CodeRabbit reported no actionable comments, all nine Advisor specialists completed without a required change, every commit is Verified, and there are zero review threads. The skipped duplicate did not execute candidate code and is accepted as non-gating workflow-event noise for this pinned merge.

jyaunches · 2026-09-09T18:37:53Z

Closing as 3 PRs were opened to address this. Taking the one most mergable

## Outcome Shared gateway startup and metadata-replacement messages now say “OpenShell gateway” without incorrectly identifying native Podman as Docker. Preflight continues to identify the selected runtime. ## Reason The reporter's [instrumented retest](#11311 (comment)) confirmed successful Podman startup and narrowed the issue to misleading legacy messages. The shared launcher retained Docker wording after it gained native Podman support. ### Related issues Fixes #11311 in its corrected messaging scope. ## Changes - Remove the Docker label from standalone startup, managed-service startup, and legacy metadata replacement. - Update gateway message assertions, the resume test's unwanted-startup check, and the Hermes startup-proof fixture. - Assert the managed-service startup message in the existing successful-start test. Strengthen the foreign-gateway and resume negative assertions, and check both startup messages as negative health fixtures in the mapped fast suite. Only three production strings change. No runtime selection, gateway lifecycle, or readiness behavior changes. ## Verification - `npx vitest run --project cli --project e2e-support src/lib/onboard/machine/handlers/gateway.test.ts src/lib/onboard/docker-driver-gateway-service.test.ts src/lib/onboard/docker-driver-gateway-env.test.ts src/lib/onboard/gateway/late-binding.test.ts test/e2e/support/hermes-gpu-startup-proof.test.ts` — 144 tests passed. - `npx vitest run --project cli --project integration src/lib/onboard/machine/handlers/gateway.test.ts test/runtime/gateway/gateway-state.test.ts` — 98 tests passed after the review repairs. - `npx tsx scripts/checks/e2e-mock-parity.mts --base origin/main --head HEAD` — passed. - `npm run validate:pr` — passed on the repaired commit. - The diff contains no secrets, API keys, or credentials. - No live E2E was dispatched manually: the changed contract is terminal wording. The existing live resume assertion was updated to retain its meaning. ## Review notes Self-review of NVIDIA/NemoClaw commit `5af927bb6f181b35687bd8ce4c4ba3d57ca00c69` covered the changed `src/lib/onboard/**` paths and both E2E test consumers. The three production changes are string replacements; control flow and security checks are unchanged. The diff removes three lines overall. CodeRabbit reviewed this commit with no actionable findings; both earlier review threads are resolved. The previous detection gap was that gateway tests did not check the managed-service message, while shared startup text still named Docker. This PR adds that assertion and updates the existing metadata and startup-proof coverage. It makes no broader Podman lifecycle qualification claim. Required CI run [34390148389](https://github.com/NVIDIA/NemoClaw/actions/runs/34390148389) passed 11 CLI shards and failed shard 6 on the inherited plugin cache-seed checksum mismatch. The fast/live parity failure is resolved. The checksum defect is identical on the recorded base and published branch; its canonical fix merged in #11314, superseding #11315. A local dependency refresh passes the 16 checksum/cache tests, but remains unpublished because the validation execution surface changed on canonical main `cad49353438e5ec6fd853eb51a1f6aded84090ff`. The published commit remains `5af927bb6f181b35687bd8ce4c4ba3d57ca00c69`; no CI waiver or broader Podman qualification is claimed. --- Signed-off-by: Aaron Erickson <aerickson@nvidia.com>  ## Summary by CodeRabbit * **User Experience** * Updated gateway startup and upgrade messages to use consistent, generic OpenShell gateway terminology. * Improved lifecycle messaging when legacy gateway metadata is encountered. * **Bug Fixes** * Startup progress messages are no longer treated as an indication that the gateway is healthy. * **Tests** * Expanded coverage for gateway startup messaging, health status handling, resume output, and GPU startup scenarios.  --------- Signed-off-by: Aaron Erickson <aerickson@nvidia.com>

fix(build): sync plugin cache seed lock digest

fbeef73

Signed-off-by: Aaron Erickson <aerickson@nvidia.com>

ericksoa marked this pull request as ready for review September 9, 2026 17:27

cjagwani mentioned this pull request Sep 9, 2026

perf(test): avoid cold gateway dependency load #11316

Merged

jyaunches closed this Sep 9, 2026

ericksoa mentioned this pull request Sep 9, 2026

fix(onboard): remove misleading Docker gateway messages #11321

Merged

Navigation Menu

Repository navigation

fix(build): sync plugin cache seed lock digest - #11315

fix(build): sync plugin cache seed lock digest#11315
ericksoa wants to merge 1 commit into
mainfrom
fix/main-plugin-cache-seed-lock

ericksoa commented Sep 9, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

copy-pr-bot Bot commented Sep 9, 2026

Uh oh!

coderabbitai Bot commented Sep 9, 2026 •

edited

Loading

Walkthrough

Changes

Uh oh!

github-code-quality Bot commented Sep 9, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Sep 9, 2026

Uh oh!

cjagwani commented Sep 9, 2026

Uh oh!

ericksoa commented Sep 9, 2026

Uh oh!

jyaunches commented Sep 9, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

ericksoa commented Sep 9, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Outcome

Reason

Related issues

Changes

Verification

Summary by CodeRabbit

Uh oh!

copy-pr-bot Bot commented Sep 9, 2026

Uh oh!

coderabbitai Bot commented Sep 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Uh oh!

github-code-quality Bot commented Sep 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Coverage Overview

TypeScript / code-coverage/plugin

TypeScript / code-coverage/cli

Uh oh!

github-actions Bot commented Sep 9, 2026

Uh oh!

cjagwani commented Sep 9, 2026

Uh oh!

ericksoa commented Sep 9, 2026

Uh oh!

jyaunches commented Sep 9, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

ericksoa commented Sep 9, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Sep 9, 2026 •

edited

Loading

github-code-quality Bot commented Sep 9, 2026 •

edited

Loading