-
Notifications
You must be signed in to change notification settings - Fork 3.1k
ci(e2e): identify PR gate controller runs by exact revision #7860
Copy link
Copy link
Labels
area: ciCI workflows, checks, release automation, or GitHub ActionsCI workflows, checks, release automation, or GitHub Actionsarea: e2eEnd-to-end tests, nightly failures, or validation infrastructureEnd-to-end tests, nightly failures, or validation infrastructurearea: observabilityLogging, metrics, tracing, diagnostics, or debug outputLogging, metrics, tracing, diagnostics, or debug output
Description
Activity
Metadata
Metadata
Assignees
Labels
area: ciCI workflows, checks, release automation, or GitHub ActionsCI workflows, checks, release automation, or GitHub Actionsarea: e2eEnd-to-end tests, nightly failures, or validation infrastructureEnd-to-end tests, nightly failures, or validation infrastructurearea: observabilityLogging, metrics, tracing, diagnostics, or debug outputLogging, metrics, tracing, diagnostics, or debug output
Summary
Trusted PR E2E controller runs triggered by
workflow_runorworkflow_dispatchare named onlyE2E Gate <event> <run-id>. During v0.0.97 release validation, simultaneous controller runs for PRs #7778 and #7811 were indistinguishable in the Actions list without opening each run. The manual approval run also omitted the supplied PR number, head SHA, and base SHA from its display name.Evidence
.github/workflows/pr-e2e-gate.yamlexposes exact identity only forpull_request_target; its fallback run name uses only event name and run ID.Expected behavior
Every PR gate controller run should expose the PR number and base revision in the Actions list before an operator opens it. The display name is diagnostic only and must not weaken the existing authenticated identity checks.
Acceptance criteria
workflow_rundisplay names include the source PR number, source head SHA, and source base SHA.workflow_dispatchapproval display names include the supplied PR number, expected head SHA, and expected base SHA.pull_request_targetnaming remains exact-revision aware.Scope
This changes internal CI observability only. It does not change E2E authorization, dispatch, or product behavior.