Repository navigation
Conversation
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
1 task
wujingyue
force-pushed
the
feat/mfsdp-recorded-schedules
branch
from
October 30, 2026 05:48
83af3f4 to
a671d00
Compare
Signed-off-by: Jingyue Wu <jingyuew@nvidia.com>
Signed-off-by: Jingyue Wu <jingyuew@nvidia.com>
Signed-off-by: Jingyue Wu <jingyuew@nvidia.com>
Signed-off-by: Jingyue Wu <jingyuew@nvidia.com>
Signed-off-by: Jingyue Wu <jingyuew@nvidia.com>
Signed-off-by: Jingyue Wu <jingyuew@nvidia.com>
Signed-off-by: Jingyue Wu <jingyuew@nvidia.com>
wujingyue
force-pushed
the
feat/mfsdp-recorded-schedules
branch
from
November 1, 2026 06:33
a671d00 to
53b3402
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Depends on #8721. Review the scheduling-only change in commit 53b34027d. The
pull-request/8721mirror is not available yet, so this draft targetsmainand includes its prerequisite commits. Both branches are rebased ontomainat88312648a; #8478 has merged.A PP/VPP schedule issues several autograd backward calls through one shared FSDP context. Ending recording after the first backward captures only part of that schedule. With caller-managed gradient synchronization, finish recording at
finish_grad_sync()after all microbatches, and check that subsequent replay has consumed the complete trace. Per-autograd deferred module cleanup remains in place.Select recorded mode for PP/VPP and EP overlap, reject registration-mode ambient contexts for these schedules, and record compute events from the combined-1F1B hooks. Evaluation gathers on demand without consuming the training trace. Ordinary eager training retains registration mode. Both modes use the single cursor and lookahead from #8721, including lookahead across forward/backward phase changes.
Validation
Eos job
6418873, exact commit53b34027d766b57f5c3f3c435fa30aea82022daa: 34 focused tests passed on each of eight H100 GPUs.Coverage includes grouped/interleaved shared-context PP/VPP call sequences, recording across multiple backward calls, incomplete-window rejection, recorded replay, evaluation between training passes, combined-1F1B owner hooks, and activation recomputation. The interleaved VPP regression checks that the next module's parameters are already materialized across a phase change, using the default one-event prefetch. The tests drive shared-context wrapping, local call sequences, and hooks directly.
Black, isort, Pylint, Ruff, and
git diff --checkpassed. The cached dev CI image uses NGC 26.08; the repository pins 26.09.Code provenance
Refactors this repository's implementation and tests. No code copied from other repositories. Existing copyright and license notices are preserved.