Repository navigation

Warn when the optimizer falls back to the global process groups - #8752

Closed

Connor-XY wants to merge 101 commits into

NVIDIA:mainfrom

Connor-XY:yx/pstate-c5-optimizer-fallbacks

Closed

Warn when the optimizer falls back to the global process groups#8752
Connor-XY wants to merge 101 commits into
NVIDIA:mainfrom
Connor-XY:yx/pstate-c5-optimizer-fallbacks

Commits on Oct 7, 2026
- Give gloo process groups a home in ProcessGroupCollection
  Connor-XY
  committed
  83a3d30
- Raise ValueError when Gloo is requested but the collection has no Gloo groups
  Connor-XY
  committed
  f62f810
- Raise ValueError when optimizer helpers get no process-group collection
  Connor-XY
  committed
  3cc4c30
- Keep the optimizer group fallback equivalent to the parallel_state path
  
  Connor-XY
  and
  claude
  committed
  37b2548
- Pass use_gloo_process_groups to the layer-wise distributed optimizer
  
  Connor-XY
  and
  claude
  committed
  cc2d3c8
- Reduce emerging-optimizer expert grad stats over the EGTP_remat axis
  
  Connor-XY
  and
  claude
  committed
  f537fee
- Check that a collection's Gloo groups mirror the optimizer's groups
  
  Connor-XY
  and
  claude
  committed
  6820332
- Test that the optimizer takes Gloo groups from the collection
  
  Connor-XY
  and
  claude
  committed
  a83f79a
- Refresh the process-group read allowlist for this change
  
  Connor-XY
  and
  claude
  committed
  57d1dc9
Commits on Oct 8, 2026
- Preserve caller process groups in T5Model initialization
  Connor-XY
  committed
  cf5f71e
- Raise ValueError for invalid T5 process-group collections
  Connor-XY
  committed
  dcccf3e
- Use already-plumbed process groups instead of global accessors
  
  Connor-XY
  and
  claude
  committed
  38167d4
- Read hierarchical CP and DP-CP groups from the collection already in scope
  
  Connor-XY
  and
  claude
  committed
  7aacc5d
- Thread the CP group through multimodal context-parallel helpers
  
  Connor-XY
  and
  claude
  committed
  d827242
- Pass the TP group into heterogeneous linear replacements
  
  Connor-XY
  and
  claude
  committed
  32b4ecb
- Pass cp_group to the direct GatherFromContextParallelRanks.apply call in tests
  
  Connor-XY
  and
  claude
  committed
  70cfaac
- Thread the schedule process groups into the hybrid CP scheduler
  
  Connor-XY
  and
  claude
  committed
  4a69710
- Use the collection's DP group in the attention consistency check
  
  Connor-XY
  and
  claude
  committed
  4458e4d
- Pass the PP group into the MTP placement check
  
  Connor-XY
  and
  claude
  committed
  b4c65d1
- Require an explicit CP group in the rotary embeddings
  
  Connor-XY
  and
  claude
  committed
  801fa62
- Require an explicit process-group collection in DotProductAttention and T5Model
  
  Connor-XY
  and
  claude
  committed
  572f3cd
- Require an explicit process-group collection in MultiTokenPredictionBlock
  
  Connor-XY
  and
  claude
  committed
  ec6c8e6
- Require an explicit process-group collection in LLaVAModel
  
  Connor-XY
  and
  claude
  committed
  843163c
- Require an explicit process-group collection in the attention classes
  
  Connor-XY
  and
  claude
  committed
  38866ba
- Require an explicit process-group collection in DSAIndexer
  
  Connor-XY
  and
  claude
  committed
  aa5f2e7
- Revert the attention-family and DSAIndexer fallback removals
  
  Connor-XY
  and
  claude
  committed
  cc86bac
- Require an explicit process-group collection in DSAIndexer
  
  Connor-XY
  and
  claude
  committed
  7558042
- Require an explicit process-group collection in Attention
  
  Connor-XY
  and
  claude
  committed
  e3f9052
- Require an explicit process-group collection in the MLA attention classes
  
  Connor-XY
  and
  claude
  committed
  91ac45e
- Revert the MLA fallback removal (second failed attempt)
  
  Connor-XY
  and
  claude
  committed
  b6b730b
- Require an explicit process-group collection in the MLA attention classes
  
  Connor-XY
  and
  claude
  committed
  60576a1
- Require an explicit process-group collection in TEGroupedLinear
  
  Connor-XY
  and
  claude
  committed
  ac90600
- Resolve the inference process groups once at the config boundary
  
  Connor-XY
  and
  claude
  committed
  653852c
- Collapse export and inference-broadcast global reads to single boundaries
  
  Connor-XY
  and
  claude
  committed
  144e1c8
- Pass pg_collection to FusedMLASelfAttention constructors added upstream
  
  Connor-XY
  and
  claude
  committed
  ddbf25d
- Pass process groups to call sites added upstream since the base
  
  Connor-XY
  and
  claude
  committed
  34f371d
- Pass process groups in pretrain_vlm and the hybrid CP scheduler tests
  
  Connor-XY
  and
  claude
  committed
  efe5f38
- Refresh explicit process-group validation and current-main callers
  Connor-XY
  committed
  30e747c
- Pass pg_collection to the grouped-linear determinism test
  Connor-XY
  committed
  6e22816
- Pass the CP group to the LLaVA vision context-parallel helpers
  Connor-XY
  committed
  18d2909
- Pass process groups in the runtime-CP attention determinism test
  Connor-XY
  committed
  b045389
- Deprecate the global process-group fallbacks instead of removing them
  Connor-XY
  committed
  925ee45
- Raise ValueError for incomplete process-group collections
  Connor-XY
  committed
  6b40180
- Give the LLaVA native-merging video test an explicit CP group
  
  Connor-XY
  and
  claude
  committed
  310798c
- Refresh the process-group read allowlist for this series
  
  Connor-XY
  and
  claude
  committed
  a9fb653
- Require an explicit process-group collection in LanguageModule
  
  Connor-XY
  and
  claude
  committed
  c6c8927
- Complete explicit model group contracts and refresh caller coverage
  Connor-XY
  committed
  b732c67
- Pass pg_collection to the quantized GPT checkpoint test model
  Connor-XY
  committed
  2176033
- Pass the caller's process groups in the T5 example and to mtp_on_this_rank
  
  Connor-XY
  and
  claude
  committed
  af5655f
- Add copyright headers to files touched by the explicit-collection change
  Connor-XY
  committed
  c16e9c3
- Pass the layer's process groups to the heterogeneous linear replacements
  
  Connor-XY
  and
  claude
  committed
  350d178
- Deprecate the LanguageModule global process-group fallback
  Connor-XY
  committed
  ccf11db
- Balance hybrid-CP samples over the GTP-remat-inclusive data-parallel group
  
  Connor-XY
  and
  claude
  committed
  2d575c1
- Raise ValueError for invalid LanguageModule process-group collections
  Connor-XY
  committed
  59402e5
- Forbid every global CP accessor in the LLaVA vision-CP tests
  
  Connor-XY
  and
  claude
  committed
  e147e51
- Expect FutureWarning from the LanguageModule fallback
  
  Connor-XY
  and
  claude
  committed
  4a1756b
- Make the deprecated process-group fallbacks visible and complete
  
  Connor-XY
  and
  claude
  committed
  86a03c0
- Refresh the process-group read allowlist for the LanguageModule change
  
  Connor-XY
  and
  claude
  committed
  f6981c1
- Merge branch 'main' into yx/pstate-gloo-in-collection
  balasaajay
  authored
  5c99ef3
Commits on Oct 9, 2026
- Merge branch 'main' into yx/pstate-p34-rebased
  
  Connor-XY
  and
  claude
  committed
  715c05b
- Patch the pipeline-group accessor in the mocked sequence-packing batch test
  
  Connor-XY
  and
  claude
  committed
  dc6ef36
- Pass pg_collection in the MLA up-projection input test
  
  Connor-XY
  and
  claude
  committed
  37285af
- Fail fast when the TRT-LLM distributed converter has no model-parallel groups
  
  Connor-XY
  and
  claude
  committed
  11e1373
- Merge branch 'yx/pstate-p34-rebased' into yx/pstate-d1-require-pg-collection
  
  Connor-XY
  and
  claude
  committed
  cd6da9c
- Give the checkpoint converter a context-parallel group
  
  Connor-XY
  and
  claude
  committed
  e3cbe16
- Let clip_qk reduce over the caller's data-parallel group
  
  Connor-XY
  and
  claude
  committed
  8d87d52
- Pass the model's DP x CP group to clip_qk
  
  Connor-XY
  and
  claude
  committed
  a9d2781
Commits on Oct 26, 2026
- Merge main into the parallel_state read removal branch
  
  Connor-XY
  and
  claude
  committed
  c0aa2e8
- Merge the parallel_state read removal branch into this branch
  
  Connor-XY
  and
  claude
  committed
  215782c
- Add a fallback warning class and process-group collection helpers
  
  Connor-XY
  and
  claude
  committed
  7b25d4a
- Count resolve_process_groups calls as guarded process-group reads
  
  Connor-XY
  and
  claude
  committed
  ea8e5eb
- Merge main into the gloo process-group branch
  
  Connor-XY
  and
  claude
  committed
  6ed6afa
- Build T5's submodules on the collection LanguageModule resolved
  
  Connor-XY
  and
  claude
  committed
  b4ee5f3
Commits on Oct 28, 2026
- Date the process-group fallbacks from the 0.21 release
  
  Connor-XY
  and
  claude
  committed
  160eeaa
Commits on Oct 29, 2026
- Bind each rank's GPU before the LLaVA tests read the device
  
  Connor-XY
  and
  claude
  committed
  434f8ae
- Merge the 0.21 fallback dates from the parallel_state read removal branch
  
  Connor-XY
  and
  claude
  committed
  74e0fe9
- Align the fallback-helper docs and tests with the 0.21 dates
  
  Connor-XY
  and
  claude
  committed
  446bd16
- Add test helpers to forbid global grid reads and build collections
  
  Connor-XY
  and
  claude
  committed
  c8f8f1c
- Set the dynamic CP fields in build_test_pg_collection
  
  Connor-XY
  and
  claude
  committed
  72dae10
- Merge the Gloo fields of the process-group collection
  
  Connor-XY
  and
  claude
  committed
  1705423
- Merge the 0.21 fallback dates from the parallel_state read removal branch
  
  Connor-XY
  and
  claude
  committed
  d548941
- Set the Gloo fields of build_test_pg_collection to None
  
  Connor-XY
  and
  claude
  committed
  576c010
Commits on Oct 30, 2026
- Merge the Gloo groups of the process-group collection from #6259
  
  Connor-XY
  and
  claude
  committed
  4f37df1
- Merge the explicit LanguageModule collection from #6303
  
  Connor-XY
  and
  claude
  committed
  0891c36
- Merge the test helpers that forbid global grid reads from #8017
  
  Connor-XY
  and
  claude
  committed
  56f09f4
- Merge the caller's data-parallel group for clip_qk from #8043
  
  Connor-XY
  and
  claude
  committed
  4dd677b
- Merge the fallback warning class and collection helpers from #8049
  
  Connor-XY
  and
  claude
  committed
  e55ff5b
- Refresh the process-group usage allowlist
  
  Connor-XY
  and
  claude
  committed
  6671c8a
- Warn when clip_qk falls back to the global data-parallel group
  
  Connor-XY
  and
  claude
  committed
  fbb73c9
- Describe GTP shards with the optimizer's own process groups
  
  Connor-XY
  and
  claude
  committed
  92d2030
- Pass the process groups to get_megatron_optimizer in tests
  
  Connor-XY
  and
  claude
  committed
  412c20d
- Warn when get_megatron_optimizer falls back to the global groups
  
  Connor-XY
  and
  claude
  committed
  2d4d3cc
- Refresh the process-group usage allowlist
  
  Connor-XY
  and
  claude
  committed
  687f10e
Commits on Nov 1, 2026
- Merge main into yx/pstate-gloo-in-collection
  
  Connor-XY
  and
  claude
  committed
  7a951c3
- Merge main into yx/pstate-p34-rebased
  
  Connor-XY
  and
  claude
  committed
  4030e3b
- Merge main into yx/pstate-b2-qk-clip-group
  
  Connor-XY
  and
  claude
  committed
  5552381
- Merge #6259 after its update to main
  
  Connor-XY
  and
  claude
  committed
  c2d65b2
- Merge #6293 after its update to main
  
  Connor-XY
  and
  claude
  committed
  d89ecce
- Merge #6293 after its update to main
  
  Connor-XY
  and
  claude
  committed
  45bd880
- Merge #6303, #8049, #8017 and #8043 after their update to main
  
  Connor-XY
  and
  claude
  committed
  e689942
- Merge the bases after their update to main
  
  Connor-XY
  and
  claude
  committed
  086fdf6

Commits

Commits on Oct 7, 2026

Commits on Oct 8, 2026

Commits on Oct 9, 2026

Commits on Oct 26, 2026

Commits on Oct 28, 2026

Commits on Oct 29, 2026

Commits on Oct 30, 2026

Commits on Nov 1, 2026