Skip to content

[Dev] Fix: Normalize MTP token ratios over DP and CP - #7570

Draft
yuzhongw-nvidia wants to merge 1 commit into
NVIDIA:devfrom
yuzhongw-nvidia:yuzhongw/codex/fix-mtp-cp-loss-normalization
Draft

yuzhongw-nvidia wants to merge 1 commit into
NVIDIA:devfrom
yuzhongw-nvidia:yuzhongw/codex/fix-mtp-cp-loss-normalization

Conversation

@yuzhongw-nvidia

Copy link
Copy Markdown
Contributor

Reduce main and MTP token counts over the gradient-normalization group before computing each microbatch ratio. Preserve local logging counts and pass the group explicitly from GPT and Hybrid models.

Document the accumulated-microbatch objective and add one parametrized gradient regression against an unpartitioned cross-entropy reference.

Related to finding 3 of #7452.

  • I, the PR author, have personally reviewed every line of this PR.

What does this PR do?

⚠️ For major changes (either in lines of code or in its impact), please make sure to first share a design doc with the team. If you're unsure what's the best way to do so, contact @NVIDIA/mcore-oncall.

Issue tracking

For PRs from open-source community contributors:

  • New features: a linked issue is required. Please open a feature request and reference it here before submitting the PR.
  • Small updates (bug fixes, minor improvements): a linked issue is recommended and will accelerate the PR review process.

Linked issue:

Contribution process

Pre-checks

  • I have added relevant unit tests
  • I have added relevant functional tests
  • If this PR adds or changes a GPU kernel (Triton, jit_fuser/torch.compile, CUDA extension, TE or external-library dispatch, or a scatter/index accumulation), I have added or updated its bit-exact determinism test and registered it in tests/unit_tests/determinism/kernels/manifest.py (guide)
  • I have added proper typing to my code Typing guidelines
  • I have added relevant documentation
  • I have run the autoformatter.sh on my PR

Code review

Feel free to message or comment @NVIDIA/mcore-oncall to help accelerate your merge into main. The less complex your PR is, the faster it will be approved and merged!

All PRs start as draft. If you open a non-draft PR, it will be automatically converted to draft.

Step 1: Mark PR as "Ready for Review"

  1. When your PR is ready, click Ready for Review.
  2. An oncall reviewer is auto-assigned and expert reviewers are notified based on your changes.
    • Some PRs may jump straight to step 2. This is determined by .github/CODEOWNERS.

⚠️ Only mark as ready once merge-conflicts are resolved and the CI is passing.
Final Review might get declined if these requirements are not fulfilled.

Step 2: Final Review

For PRs that change megatron/core, once all expert reviewers have approved, the Final Review label is applied automatically and final reviewers are assigned.

For PRs outside megatron/core, this step is skipped.

Step 3: Approved

Once all required reviewers have approved, the Approved label is applied automatically.

Merge

Any member of mcore-engineers will be able to merge your PR.

Reduce main and MTP token counts over the gradient-normalization group
before computing each microbatch ratio. Preserve local logging counts
and pass the group explicitly from GPT and Hybrid models.

Document the accumulated-microbatch objective and add one parametrized
gradient regression against an unpartitioned cross-entropy reference.

Related to finding 3 of NVIDIA#7452.

Signed-off-by: Yuzhong Wang <yuzhongw@computelab-frontend-3.nvidia.com>
@copy-pr-bot

copy-pr-bot Bot commented Sep 22, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@yuzhongw-nvidia

Copy link
Copy Markdown
Contributor Author

/claude strict-review

@Connor-XY

Copy link
Copy Markdown
Contributor

@yuzhongw-nvidia @cuichenx, linking the remaining coordination item from #7452 finding 3: this draft targets DP+CP token ratios, while #7498 targets CP normalization and explicitly preserves its existing DP/microbatch objective.

Could you agree on the intended objective and consolidate the overlap, including unequal DP/CP valid-token counts and accumulated microbatches? Please link the agreed scope and regression results back to #7452. Both proposals are still drafts, so the remaining task is reconciling and validating them.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants