Repository navigation
[Dev] Fix: Normalize MTP token ratios over DP and CP - #7570
Draft
yuzhongw-nvidia wants to merge 1 commit into
Draft
yuzhongw-nvidia wants to merge 1 commit into
yuzhongw-nvidia wants to merge 1 commit into
Conversation
Reduce main and MTP token counts over the gradient-normalization group before computing each microbatch ratio. Preserve local logging counts and pass the group explicitly from GPT and Hybrid models. Document the accumulated-microbatch objective and add one parametrized gradient regression against an unpartitioned cross-entropy reference. Related to finding 3 of NVIDIA#7452. Signed-off-by: Yuzhong Wang <yuzhongw@computelab-frontend-3.nvidia.com>
Contributor
Author
|
/claude strict-review |
Contributor
|
@yuzhongw-nvidia @cuichenx, linking the remaining coordination item from #7452 finding 3: this draft targets DP+CP token ratios, while #7498 targets CP normalization and explicitly preserves its existing DP/microbatch objective. Could you agree on the intended objective and consolidate the overlap, including unequal DP/CP valid-token counts and accumulated microbatches? Please link the agreed scope and regression results back to #7452. Both proposals are still drafts, so the remaining task is reconciling and validating them. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reduce main and MTP token counts over the gradient-normalization group before computing each microbatch ratio. Preserve local logging counts and pass the group explicitly from GPT and Hybrid models.
Document the accumulated-microbatch objective and add one parametrized gradient regression against an unpartitioned cross-entropy reference.
Related to finding 3 of #7452.
What does this PR do?
Issue tracking
For PRs from open-source community contributors:
Linked issue:
Contribution process
Pre-checks
jit_fuser/torch.compile, CUDA extension, TE or external-library dispatch, or a scatter/index accumulation), I have added or updated its bit-exact determinism test and registered it intests/unit_tests/determinism/kernels/manifest.py(guide)Code review
Feel free to message or comment @NVIDIA/mcore-oncall to help accelerate your merge into main. The less complex your PR is, the faster it will be approved and merged!
All PRs start as draft. If you open a non-draft PR, it will be automatically converted to draft.
Step 1: Mark PR as "Ready for Review"
.github/CODEOWNERS.Final Review might get declined if these requirements are not fulfilled.
Step 2: Final Review
For PRs that change
megatron/core, once all expert reviewers have approved, theFinal Reviewlabel is applied automatically and final reviewers are assigned.For PRs outside
megatron/core, this step is skipped.Step 3: Approved
Once all required reviewers have approved, the
Approvedlabel is applied automatically.Merge
Any member of mcore-engineers will be able to merge your PR.