Repository navigation
test(ci): measure selective units for PR #7467 - #7505
Closed
balasaajay wants to merge 1 commit into
Closed
balasaajay wants to merge 1 commit into
balasaajay wants to merge 1 commit into
Conversation
GTP has already accumulated its reduced gradient into main_grad when it invokes the manual DDP callback. A stale autograd placeholder can still be added when zero_out_wgrad overrides grad_added_to_main_grad. Capturing that redundant add can retain a warmup allocation after it is released. Clear the placeholder at the GTP notification boundary while preserving the dummy returned to autograd and generic DDP accumulation semantics. Add regression coverage for ordinary DDP accumulation, repeated GTP backward uses, and replay after releasing the warmup dummy. Signed-off-by: Jiangfei Duan <jiangfeid@nvidia.com> Signed-off-by: Ajay Balasa <abalasa@nvidia.com>
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
Contributor
Author
|
/ok to test f01272c |
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Temporary Testmon cache experiment using the changes from #7467 on main. This draft is for measurement and will be closed after its unit-test buckets finish, without waiting for functional tests. It is not intended to merge.
Source head:
2b8404f3c0d6778cb328055a261fa91b7eece5a0. Its full unit CI passed all 39 unit buckets.Shared main baseline recorded 12,934 executed tests across 39 buckets. This experiment measures cache reuse, selected tests, fallbacks, and test-count reduction against that baseline.
Prepared main:
e648932ff21ff3fc2fb2e713376a73221adc7f86. Local formatting/import checks are recorded in the preparation metadata. The only requested CI label isRun selective unit tests.Validation limits: