Repository navigation
Conversation
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
philipcmonk
marked this pull request as ready for review
September 18, 2026 05:30
philipcmonk
force-pushed
the
pmonk/tensor-metrics-training-integration-main
branch
from
September 18, 2026 20:16
81c55ba to
1466fa2
Compare
Build scheduled tensor metric observers from the logger configuration, capture forward observations, and collect parameter and gradient metrics before the optimizer step. Give metric iterations their own fault-tolerance timeout section. Preserve the current tokenizer startup option, sample accounting, training callbacks, and schedule plumbing. Adapt the integration fixtures to current training configuration ownership and cover timeout transitions with regression tests. Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Signed-off-by: Philip Monk <pmonk@nvidia.com>
philipcmonk
force-pushed
the
pmonk/tensor-metrics-training-integration-main
branch
from
October 26, 2026 23:09
1466fa2 to
b254180
Compare
deepakn94
approved these changes
Oct 27, 2026
|
🔄 Merge queue validation started! You can track the progress here: https://github.com/NVIDIA/Megatron-LM/actions/runs/40576553756 |
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recreated version of #6650, which was automatically closed when its stacked base branch was deleted. See #6650 for the original description and review discussion.
This PR targets
mainand includes the two metric-definition commits from #7471, followed by the three integration commits from #6650, including the fault-tolerance timeout fix. Conflicts with current main were resolved while preserving its training callbacks and schedule-plumbing tests.Depends on #7471, but intentionally targets
mainto avoid another automatic closure when a temporary base branch is deleted.